Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/plugins/event_log/server/es - retries createIlmPolicyIfNotExists with 1 retry #156061

Closed
kibanamachine opened this issue Apr 27, 2023 · 8 comments · Fixed by #158721
Closed

Failing test: Jest Tests.x-pack/plugins/event_log/server/es - retries createIlmPolicyIfNotExists with 1 retry #156061

kibanamachine opened this issue Apr 27, 2023 · 8 comments · Fixed by #158721
Assignees
@doakalexi
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 27, 2023 •
edited
Loading

A test failed on a tracked branch

Error: expect(received).toBeGreaterThanOrEqual(expected)

Expected: >= 20
Received:    19
    at Object.toBeGreaterThanOrEqual (/var/lib/buildkite-agent/builds/kb-n2-4-spot-c9d8e3c412a9900e/elastic/kibana-on-merge/kibana/x-pack/plugins/event_log/server/es/init.test.ts:478:25)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Apr 27, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 27, 2023
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Apr 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 27, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@ymao1 ymao1 moved this from Awaiting Triage to Todo in AppEx: ResponseOps - Execution & Connectors May 18, 2023
@ersin-erdal ersin-erdal self-assigned this May 26, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue May 30, 2023
@mistic
skip flaky suite (#156061)
b529887
@mistic
Copy link
Member

mistic commented May 30, 2023

Skipped.

main: b529887

@ersin-erdal ersin-erdal mentioned this issue May 31, 2023
Merged
@ersin-erdal ersin-erdal moved this from In Progress to In Review in AppEx: ResponseOps - Execution & Connectors May 31, 2023
ersin-erdal added a commit that referenced this issue Jun 1, 2023
@ersin-erdal
[EventLog] Use performance.now() rather than Date.now() to calculate …
72fa065 
…elapsed time in tests (#158721)

Resolves: #156061

Since all the failed CI results show actual elapsed time as `19` rather
than `20` (expected), the issue seems like an inaccurate time
calculation caused by `Date.now()` method.

Replacing `Date.now()` with the more precise `performance.now()` method
may solve the problem.
@kibanamachine kibanamachine reopened this Jun 15, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Jun 15, 2023
@mistic
skip flaky suite (#156061)
3f55d18
@mistic
Copy link
Member

mistic commented Jun 15, 2023

Skipped.

main: 3f55d18

@mikecote mikecote moved this from Awaiting Triage to Todo in AppEx: ResponseOps - Execution & Connectors Jun 21, 2023
@doakalexi doakalexi self-assigned this Jul 26, 2023
@doakalexi doakalexi moved this from Todo to In Progress in AppEx: ResponseOps - Execution & Connectors Jul 26, 2023
@doakalexi doakalexi mentioned this issue Jul 26, 2023
Merged
@doakalexi doakalexi moved this from In Progress to In Review in AppEx: ResponseOps - Execution & Connectors Jul 26, 2023
doakalexi added a commit that referenced this issue Jul 31, 2023
@doakalexi
[ResponseOps][Alerting] Flaky test x-pack/plugins/event_log/server/es (…
e66d949 
…#162558)

#156061

## Summary

Fixes flaky test by adding ceil(). When it fails the time elapsed is
close to the `MOCK_RETRY_DELAY` of 20 (like 19.7), so rounding up helps
with the flakiness
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@doakalexi
[ResponseOps][Alerting] Flaky test x-pack/plugins/event_log/server/es (…
b966dde 
…elastic#162558)

elastic#156061

## Summary

Fixes flaky test by adding ceil(). When it fails the time elapsed is
close to the `MOCK_RETRY_DELAY` of 20 (like 19.7), so rounding up helps
with the flakiness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doakalexi doakalexi

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
AppEx: ResponseOps - Execution & Connectors
Status: Done
Milestone
No milestone
5 participants
@mistic @elasticmachine @kibanamachine @ersin-erdal @doakalexi