Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Viewer user - Enable/disable status alerts not disabled for reader users #155937

Closed
dominiqueclarke opened this issue Apr 26, 2023 · 2 comments · Fixed by #156146
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.8.0

Comments

@dominiqueclarke
Copy link
Contributor

dominiqueclarke commented Apr 26, 2023

Kibana version: 8.8.0

Description of the problem including expected versus actual behavior:

The enable/disable status alerts button on the monitor metric card on overview is not disabled for viewer users.

Attempting to use it will result in an error toast.

Screen Shot 2023-04-26 at 3 36 57 PM

Steps to reproduce:

  1. Create at least one monitor
  2. Create a user with viewer role
  3. Navigate to overview. Click on the actions button on the overview metric card. Notice disable monitor status alerts is not disabled
  4. Click the button. Observe an error toast

Note from @paulb-elastic: might be worth doing #156028 at the same time

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.8.0 labels Apr 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 self-assigned this Apr 28, 2023
shahzad31 added a commit that referenced this issue Apr 28, 2023
…156146)

## Summary

Fixes #155937

For viewer user tooltip will be displayed and button is disabled.

Also fixed loading position for manual test run loader.

<img width="1770" alt="image"
src="https://user-images.githubusercontent.com/3505601/235106034-7e758a5d-7291-47a2-8a46-2327b367e4a8.png">
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Apr 28, 2023
…lastic#156146)

## Summary

Fixes elastic#155937

For viewer user tooltip will be displayed and button is disabled.

Also fixed loading position for manual test run loader.

<img width="1770" alt="image"
src="https://user-images.githubusercontent.com/3505601/235106034-7e758a5d-7291-47a2-8a46-2327b367e4a8.png">

(cherry picked from commit dab1409)
kibanamachine referenced this issue Apr 28, 2023
…sions (#156146) (#156167)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Synthetics] Disable/enable status alert for viewer user permissions
(#156146)](#156146)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-28T11:18:35Z","message":"[Synthetics]
Disable/enable status alert for viewer user permissions (#156146)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/155937\n\nFor
viewer user tooltip will be displayed and button is disabled.\n\nAlso
fixed loading position for manual test run loader.\n\n<img
width=\"1770\"
alt=\"image\"\nsrc=\"https://user-images.githubusercontent.com/3505601/235106034-7e758a5d-7291-47a2-8a46-2327b367e4a8.png\">","sha":"dab1409fef83810b12d121ef6c9d2ecda60b4ed3","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:uptime","release_note:skip","v8.8.0","v8.9.0"],"number":156146,"url":"https://github.com/elastic/kibana/pull/156146","mergeCommit":{"message":"[Synthetics]
Disable/enable status alert for viewer user permissions (#156146)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/155937\n\nFor
viewer user tooltip will be displayed and button is disabled.\n\nAlso
fixed loading position for manual test run loader.\n\n<img
width=\"1770\"
alt=\"image\"\nsrc=\"https://user-images.githubusercontent.com/3505601/235106034-7e758a5d-7291-47a2-8a46-2327b367e4a8.png\">","sha":"dab1409fef83810b12d121ef6c9d2ecda60b4ed3"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156146","number":156146,"mergeCommit":{"message":"[Synthetics]
Disable/enable status alert for viewer user permissions (#156146)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/155937\n\nFor
viewer user tooltip will be displayed and button is disabled.\n\nAlso
fixed loading position for manual test run loader.\n\n<img
width=\"1770\"
alt=\"image\"\nsrc=\"https://user-images.githubusercontent.com/3505601/235106034-7e758a5d-7291-47a2-8a46-2327b367e4a8.png\">","sha":"dab1409fef83810b12d121ef6c9d2ecda60b4ed3"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <[email protected]>
@shahzad31
Copy link
Contributor

POST FF Testing looks good !!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.8.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants