Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Removed Legacy Field Stats #154841

Closed
kertal opened this issue Apr 12, 2023 · 1 comment · Fixed by #155503
Closed

[Discover] Removed Legacy Field Stats #154841

kertal opened this issue Apr 12, 2023 · 1 comment · Fixed by #155503
Assignees
@jughosta
Labels
chore Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Apr 12, 2023 •
edited
Loading

Discovered while reviewing #153538

As mentioned in this comment in the code:

kibana/src/plugins/discover/public/application/main/components/sidebar/discover_field.tsx

Line 286 in 965f9c9

{showLegacyFieldStats ? ( // TODO: Deprecate and remove after ~v8.7

We should be fine to remove legacy field stats, this would also mean removing the corresponding uiSetting

kibana/src/plugins/discover/public/application/main/components/sidebar/discover_field.tsx

Line 282 in 965f9c9

const showLegacyFieldStats = services.uiSettings.get(SHOW_LEGACY_FIELD_TOP_VALUES);

@kertal kertal added chore Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Apr 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added 8.9 candidate loe:small Small Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Apr 12, 2023
@jughosta jughosta mentioned this issue Apr 21, 2023
Merged
jughosta added a commit that referenced this issue Apr 27, 2023
@jughosta
[Discover] Remove legacy field stats (#155503)
c6b6e28 
Closes #154841

## Summary

This PR removes legacy field stats which were shown in field popover
before. They were based on loaded hits and were less precise than the
current default field stats (they are based now on 5000 documents per
shard sample).

Before (opt-in option):
<img width="500" alt="Screenshot 2023-04-21 at 14 26 57"
src="https://user-images.githubusercontent.com/1415710/233635136-ebc4017e-71c3-499d-96ac-544e26ea4b49.png">

After:
<img width="500" alt="Screenshot 2023-04-21 at 14 26 20"
src="https://user-images.githubusercontent.com/1415710/233635194-8c60fd05-5db6-40e0-abcd-672689932a83.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
chore Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Remove legacy field stats jughosta/kibana
3 participants
@kertal @jughosta @elasticmachine