-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensures ARIA attributes are allowed for an element's role violation on global loading indicator #153597
Comments
Pinging @elastic/kibana-presentation (Team:Presentation) |
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Tagging @elastic/appex-sharedux, since they own the |
@Heenawter Thank you for testing this and following up with a screenshot. Adding an For the moment, you could remove the I think there's an opportunity to improve our default experience for assistive technology, but will take some research into the history and UX thinking. |
Thanks for the investigation Hannah <3 @Heenawter |
## Summary Closes #153597 In full screen, the loading indicator fails a11y tests. By removing the aria-label and aria-hidden attributes, this allows the validation to pass. #153597 (comment) This PR also introduces optional props for max and value props on the `EuiProgress` component to provide consumers of the component greater ability to define how the component is being used. [Information](https://eui.elastic.co/#/display/progress#progress-with-values) on the max and value props can be found in the [EUI docs](https://eui.elastic.co/#/display/progress#progress-with-values). --------- Co-authored-by: kibanamachine <[email protected]>
Kibana version: main
Browser version: chrome latest
Browser OS version: OS X
Describe the bug: Dashboard full screen a11y test is failing because of the way we are using globalLoadingIndicator is violating the rule "Ensures ARIA attributes are allowed for an element's role"
Accessibility Tests
test/accessibility/apps/dashboard.ts
Buildkite Job
https://buildkite.com/elastic/kibana-pull-request/builds/115148#01870fc1-8e11-4537-b8c8-2456c4c14caf
Error: a11y report:
VIOLATION
[aria-allowed-attr]: Ensures ARIA attributes are allowed for an element's role
Impact: serious
Help: https://dequeuniversity.com/rules/axe/4.6/aria-allowed-attr?application=axeAPI
Elements:
-
at AccessibilityService.assertValidAxeReport (a11y.ts:75:13)
at AccessibilityService.testAppSnapshot (a11y.ts:48:10)
at runMicrotasks ()
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at Context. (dashboard.ts:112:7)
at Object.apply (wrap_function.js:73:16)
\
The text was updated successfully, but these errors were encountered: