Kibana shouldn't display internal server error for deleted saved queries on discover in notification banner #153497
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
:DataDiscovery/fix-it-week
Feature:Discover
Discover Application
impact:low
Addressing this issue will have a low level of impact on the quality/strength of our product.
loe:needs-research
This issue requires some research before it can be worked on or estimated
Team:DataDiscovery
Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Comments
bhavyarm
added
bug
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
Thx @bhavyarm, not sure we should remove this error message or improve it, will discuss with the team |
KOTungseth
added
impact:low
|
Forgot to update, we should improve the error message, it's ok to display an error message, but it should be more precise, thx for reporting @bhavyarm |
1 task
lukasolson
added a commit
that referenced
this issue
Aug 22, 2023
## Summary Resolves #153497. Updates the saved query service to properly handle & return errors from the saved object client. Instead of displaying "internal server error" and returning 500, specific error messages occur for corresponding saved object client errors. After:  ### To do - [x] API integration tests --------- Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Aug 22, 2023
## Summary Resolves elastic#153497. Updates the saved query service to properly handle & return errors from the saved object client. Instead of displaying "internal server error" and returning 500, specific error messages occur for corresponding saved object client errors. After:  ### To do - [x] API integration tests --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 57b7efc)
kibanamachine
referenced
this issue
Aug 22, 2023
# Backport This will backport the following commits from `main` to `8.10`: - [Update error handling for saved query service (#163904)](#163904) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lukas Olson","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-22T20:09:00Z","message":"Update error handling for saved query service (#163904)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/153497.\r\n\r\nUpdates the saved query service to properly handle & return errors from\r\nthe saved object client. Instead of displaying \"internal server error\"\r\nand returning 500, specific error messages occur for corresponding saved\r\nobject client errors.\r\n\r\nAfter:\r\n\r\n\r\n\r\n\r\n### To do\r\n\r\n- [x] API integration tests\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"57b7efc3eb3e03bb26e7a185342807b8e083a1a7","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","v8.10.0","v8.11.0"],"number":163904,"url":"https://github.com/elastic/kibana/pull/163904","mergeCommit":{"message":"Update error handling for saved query service (#163904)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/153497.\r\n\r\nUpdates the saved query service to properly handle & return errors from\r\nthe saved object client. Instead of displaying \"internal server error\"\r\nand returning 500, specific error messages occur for corresponding saved\r\nobject client errors.\r\n\r\nAfter:\r\n\r\n\r\n\r\n\r\n### To do\r\n\r\n- [x] API integration tests\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"57b7efc3eb3e03bb26e7a185342807b8e083a1a7"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163904","number":163904,"mergeCommit":{"message":"Update error handling for saved query service (#163904)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/153497.\r\n\r\nUpdates the saved query service to properly handle & return errors from\r\nthe saved object client. Instead of displaying \"internal server error\"\r\nand returning 500, specific error messages occur for corresponding saved\r\nobject client errors.\r\n\r\nAfter:\r\n\r\n\r\n\r\n\r\n### To do\r\n\r\n- [x] API integration tests\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"57b7efc3eb3e03bb26e7a185342807b8e083a1a7"}}]}] BACKPORT--> Co-authored-by: Lukas Olson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kibana version: 8.7.0 BC6
Elasticsearch version: 8.7.0 BC6
Browser version: chrome latest
Browser OS version: OS X
Original install method (e.g. download page, yum, from source, etc.): from staging
Describe the bug: Kibana displays saved object id <> cannot found. Internal server error on discover if user deletes the current saved object query from manage saved queries -> saved object management table -> delete saved query->navigate back to discover.
internal_server_2.mp4
The text was updated successfully, but these errors were encountered: