Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maps] remove Maps data view telemetry #152121

Closed
nreese opened this issue Feb 24, 2023 · 1 comment · Fixed by #152124
Closed

[maps] remove Maps data view telemetry #152121

nreese opened this issue Feb 24, 2023 · 1 comment · Fixed by #152124
Assignees
@nreese
Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps Feature:Telemetry impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nreese
Copy link
Contributor

nreese commented Feb 24, 2023 •
edited
Loading

Maps data view telemetry iterates through all data views gathering:

  • stack_stats.kibana.plugins.maps.indexPatternsWithGeoFieldCount
  • stack_stats.kibana.plugins.maps.indexPatternsWithGeoPointFieldCount
  • stack_stats.kibana.plugins.maps.indexPatternsWithGeoShapeFieldCount
  • stack_stats.kibana.plugins.maps.geoShapeAggLayersCount

This telemetry gathering causes memory and event loop spikes in clusters with a large number of data views.

The use case for the data view telemetry is to get an idea of the number of clusters that have geo data but don't have maps (determine the market size for Maps). Existing cluster stats provide this level of information and the maps data view telemetry is not needed.

Maps data view telemetry can be replaced with cluster_stats.indices.mappings.field_types.

{
  "name": "geo_point",
  "count": 4,
  "index_count": 3,
  "script_count": 0
}

geoShapeAggLayersCount can not be replaced with cluster_stats. Upon discussion, geoShapeAggLayersCount was not being used and is no longer needed. In the future, it would be possible to gather geoShapeAggLayersCount with usage based collectors when Maps are opened.
@nreese nreese added bug Fixes for quality problems that affect the customer experience Feature:Telemetry Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Feature:Maps labels Feb 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese self-assigned this Feb 24, 2023
@nreese nreese mentioned this issue Feb 24, 2023
Merged
nreese added a commit that referenced this issue Feb 28, 2023
@nreese @kibanamachine
[maps] remove Maps data view telemetry (#152124)
391220a 
Fixes #152121

Removes data view telemetry collection

---------

Co-authored-by: kibanamachine <[email protected]>
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this issue Mar 10, 2023
@nreese @kibanamachine @bmorelli25
[maps] remove Maps data view telemetry (elastic#152124)
14e83f8 
Fixes elastic#152121

Removes data view telemetry collection

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps Feature:Telemetry impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[maps] remove Maps data view telemetry nreese/kibana
2 participants
@nreese @elasticmachine