Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] No prebuilt rules available to install when users visit the rules management page for the first time #150306

Closed
xcrzx opened this issue Feb 6, 2023 · 2 comments · Fixed by #150292
Closed

[Security Solution] No prebuilt rules available to install when users visit the rules management page for the first time #150306

xcrzx opened this issue Feb 6, 2023 · 2 comments · Fixed by #150292
Assignees
@xcrzx
Labels
8.7 candidate bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@xcrzx
Copy link
Contributor

xcrzx commented Feb 6, 2023

Steps to reproduce

  1. Ensure that the detection engine package is not installed:

2. Navigate to the rules management page.

Expected result

Users should see the "Load Elastic Prebuilt Rules" button and should be able to install prebuilt rules.

Actual result

The "Load Elastic Prebuilt Rules" button is not visible, and users cannot install prebuilt rules.

It is possible to install prebuilt rules only after page reload, as the rules package installation is happening in the background. However, for users, that behavior might not be apparent. Therefore, we need to clearly indicate the detection engine package being installed by showing a spinner, for example.
@xcrzx xcrzx added bug Fixes for quality problems that affect the customer experience Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area 8.7 candidate labels Feb 6, 2023
@xcrzx xcrzx self-assigned this Feb 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@xcrzx xcrzx mentioned this issue Feb 6, 2023
Merged
@banderror banderror added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Feb 6, 2023
@xcrzx xcrzx mentioned this issue Feb 8, 2023
Open
xcrzx added a commit that referenced this issue Feb 13, 2023
@xcrzx
[Security Solution] Invalidate prebuilt rules status after package up…
4f1f2a8 
…grade or installation (#150292)

**Resolves: #150306

## Summary

Fixes the Load Prebuilt rules button not visible when users visit the
rules management page for the first time (no prebuilt detection rules
package installed).

## Steps to test

1. Ensure that the detection engine package is not installed: <img
src="https://user-images.githubusercontent.com/1938181/216949857-a49731f3-535e-4813-95d3-62b2995500bb.png"
width="600" />
2. Navigate to the rules management page.

### Previously

The "Load Elastic Prebuilt Rules" button is not visible, and users
cannot install prebuilt rules.

<img
src="https://user-images.githubusercontent.com/1938181/216950430-4c57a3ad-3146-40a0-82c2-08c4fc2f65c3.png"
width="600" />

### With the fix

Users now see loading animation, indicating that the package
installation happens in the background. Once the package installation
finishes, users see the Load Prebuilt rules button appear.


https://user-images.githubusercontent.com/1938181/217585144-879fe288-0ede-4e01-b585-6aced1d89379.mov
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Feb 13, 2023
@xcrzx
[Security Solution] Invalidate prebuilt rules status after package up…
c558d6f 
…grade or installation (elastic#150292)

**Resolves: elastic#150306

## Summary

Fixes the Load Prebuilt rules button not visible when users visit the
rules management page for the first time (no prebuilt detection rules
package installed).

## Steps to test

1. Ensure that the detection engine package is not installed: <img
src="https://user-images.githubusercontent.com/1938181/216949857-a49731f3-535e-4813-95d3-62b2995500bb.png"
width="600" />
2. Navigate to the rules management page.

### Previously

The "Load Elastic Prebuilt Rules" button is not visible, and users
cannot install prebuilt rules.

<img
src="https://user-images.githubusercontent.com/1938181/216950430-4c57a3ad-3146-40a0-82c2-08c4fc2f65c3.png"
width="600" />

### With the fix

Users now see loading animation, indicating that the package
installation happens in the background. Once the package installation
finishes, users see the Load Prebuilt rules button appear.

https://user-images.githubusercontent.com/1938181/217585144-879fe288-0ede-4e01-b585-6aced1d89379.mov
(cherry picked from commit 4f1f2a8)
kibanamachine referenced this issue Feb 13, 2023
@kibanamachine @xcrzx
[8.7] [Security Solution] Invalidate prebuilt rules status after pack…
fc14852 
…age upgrade or installation (#150292) (#151019)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Security Solution] Invalidate prebuilt rules status after package
upgrade or installation
(#150292)](#150292)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dmitrii
Shevchenko","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-13T15:00:20Z","message":"[Security
Solution] Invalidate prebuilt rules status after package upgrade or
installation (#150292)\n\n**Resolves:
https://github.com/elastic/kibana/issues/150306**\r\n\r\n##
Summary\r\n\r\nFixes the Load Prebuilt rules button not visible when
users visit the\r\nrules management page for the first time (no prebuilt
detection rules\r\npackage installed).\r\n\r\n## Steps to test\r\n\r\n1.
Ensure that the detection engine package is not installed:
<img\r\nsrc=\"https://user-images.githubusercontent.com/1938181/216949857-a49731f3-535e-4813-95d3-62b2995500bb.png\"\r\nwidth=\"600\"
/>\r\n2. Navigate to the rules management page.\r\n\r\n###
Previously\r\n\r\nThe \"Load Elastic Prebuilt Rules\" button is not
visible, and users\r\ncannot install prebuilt
rules.\r\n\r\n<img\r\nsrc=\"https://user-images.githubusercontent.com/1938181/216950430-4c57a3ad-3146-40a0-82c2-08c4fc2f65c3.png\"\r\nwidth=\"600\"
/>\r\n\r\n### With the fix\r\n\r\nUsers now see loading animation,
indicating that the package\r\ninstallation happens in the background.
Once the package installation\r\nfinishes, users see the Load Prebuilt
rules button
appear.\r\n\r\n\r\nhttps://user-images.githubusercontent.com/1938181/217585144-879fe288-0ede-4e01-b585-6aced1d89379.mov","sha":"4f1f2a84fdf3421d6b56aac82274dee2e881d376","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","impact:high","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection
Rules","Feature:Prebuilt Detection
Rules","v8.7.0","v8.8.0"],"number":150292,"url":"https://github.com/elastic/kibana/pull/150292","mergeCommit":{"message":"[Security
Solution] Invalidate prebuilt rules status after package upgrade or
installation (#150292)\n\n**Resolves:
https://github.com/elastic/kibana/issues/150306**\r\n\r\n##
Summary\r\n\r\nFixes the Load Prebuilt rules button not visible when
users visit the\r\nrules management page for the first time (no prebuilt
detection rules\r\npackage installed).\r\n\r\n## Steps to test\r\n\r\n1.
Ensure that the detection engine package is not installed:
<img\r\nsrc=\"https://user-images.githubusercontent.com/1938181/216949857-a49731f3-535e-4813-95d3-62b2995500bb.png\"\r\nwidth=\"600\"
/>\r\n2. Navigate to the rules management page.\r\n\r\n###
Previously\r\n\r\nThe \"Load Elastic Prebuilt Rules\" button is not
visible, and users\r\ncannot install prebuilt
rules.\r\n\r\n<img\r\nsrc=\"https://user-images.githubusercontent.com/1938181/216950430-4c57a3ad-3146-40a0-82c2-08c4fc2f65c3.png\"\r\nwidth=\"600\"
/>\r\n\r\n### With the fix\r\n\r\nUsers now see loading animation,
indicating that the package\r\ninstallation happens in the background.
Once the package installation\r\nfinishes, users see the Load Prebuilt
rules button
appear.\r\n\r\n\r\nhttps://user-images.githubusercontent.com/1938181/217585144-879fe288-0ede-4e01-b585-6aced1d89379.mov","sha":"4f1f2a84fdf3421d6b56aac82274dee2e881d376"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150292","number":150292,"mergeCommit":{"message":"[Security
Solution] Invalidate prebuilt rules status after package upgrade or
installation (#150292)\n\n**Resolves:
https://github.com/elastic/kibana/issues/150306**\r\n\r\n##
Summary\r\n\r\nFixes the Load Prebuilt rules button not visible when
users visit the\r\nrules management page for the first time (no prebuilt
detection rules\r\npackage installed).\r\n\r\n## Steps to test\r\n\r\n1.
Ensure that the detection engine package is not installed:
<img\r\nsrc=\"https://user-images.githubusercontent.com/1938181/216949857-a49731f3-535e-4813-95d3-62b2995500bb.png\"\r\nwidth=\"600\"
/>\r\n2. Navigate to the rules management page.\r\n\r\n###
Previously\r\n\r\nThe \"Load Elastic Prebuilt Rules\" button is not
visible, and users\r\ncannot install prebuilt
rules.\r\n\r\n<img\r\nsrc=\"https://user-images.githubusercontent.com/1938181/216950430-4c57a3ad-3146-40a0-82c2-08c4fc2f65c3.png\"\r\nwidth=\"600\"
/>\r\n\r\n### With the fix\r\n\r\nUsers now see loading animation,
indicating that the package\r\ninstallation happens in the background.
Once the package installation\r\nfinishes, users see the Load Prebuilt
rules button
appear.\r\n\r\n\r\nhttps://user-images.githubusercontent.com/1938181/217585144-879fe288-0ede-4e01-b585-6aced1d89379.mov","sha":"4f1f2a84fdf3421d6b56aac82274dee2e881d376"}}]}]
BACKPORT-->

Co-authored-by: Dmitrii Shevchenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcrzx xcrzx

Labels
8.7 candidate bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
3 participants
@xcrzx @banderror @elasticmachine