[Lens] Keep the filters order in the partition chart legend #149034
Labels
enhancement
New value added to drive a business result
Feature:Lens
impact:low
Addressing this issue will have a low level of impact on the quality/strength of our product.
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
Comments
41 tasks
dej611
changed the title
dej611
added
enhancement
3 tasks
drewdaemon
added
the
impact:low
2 tasks
9 tasks
dej611
added a commit
that referenced
this issue
Apr 17, 2023
## Summary Fix #149034 This PR adds the legend order sync with Lens filters when there's a single category grouping dimension.   While working on the feature I've noticed also that the `Nested` switch in the Legend popover was always enabled when visible, also when there's a single grouping dimension and the nesting won't apply. So I've created a new `disabled` state for this specific case with a tooltip explanation of the disabled state. <img width="862" alt="Screenshot 2023-04-12 at 14 42 10" src="https://user-images.githubusercontent.com/924948/231466601-eef3d9af-1c98-4e97-b497-529f3aee412f.png"> <img width="861" alt="Screenshot 2023-04-12 at 14 42 26" src="https://user-images.githubusercontent.com/924948/231466605-8228b922-f92c-4928-a03c-4ba540c38427.png"> <img width="850" alt="Screenshot 2023-04-12 at 14 43 03" src="https://user-images.githubusercontent.com/924948/231466608-9a196284-1dff-4ef0-8495-d6721dbce2ae.png"> <img width="851" alt="Screenshot 2023-04-12 at 14 43 22" src="https://user-images.githubusercontent.com/924948/231466611-0a7facbc-7f05-4206-b035-c481c6e4400f.png"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Pie legend items order is not respecting Filters items order.
Blocked by elastic/elastic-charts#1935
The text was updated successfully, but these errors were encountered: