Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: License plugin API Integration Tests.x-pack/test/licensing_plugin/server/updates·ts - Licensing plugin server client changes in license types properly recognize an enterprise license #148313

Closed
kibanamachine opened this issue Jan 3, 2023 · 13 comments · Fixed by #182712
Closed

Failing test: License plugin API Integration Tests.x-pack/test/licensing_plugin/server/updates·ts - Licensing plugin server client changes in license types properly recognize an enterprise license #148313

kibanamachine opened this issue Jan 3, 2023 · 13 comments · Fixed by #182712
Assignees
@afharo
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 3, 2023 •
edited
Loading

A test failed on a tracked branch

Error: expected 'expired' to equal 'valid'
    at Assertion.assert (/opt/local-ssd/buildkite/builds/kb-n2-4-dc7fe0c49571bfef/elastic/kibana-on-merge/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (/opt/local-ssd/buildkite/builds/kb-n2-4-dc7fe0c49571bfef/elastic/kibana-on-merge/kibana/node_modules/@kbn/expect/expect.js:227:8)
    at Assertion.be (/opt/local-ssd/buildkite/builds/kb-n2-4-dc7fe0c49571bfef/elastic/kibana-on-merge/kibana/node_modules/@kbn/expect/expect.js:69:22)
    at Object.startEnterprise (test/licensing_plugin/scenario.ts:94:47)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Context.<anonymous> (test/licensing_plugin/server/updates.ts:69:7)
    at Object.apply (/opt/local-ssd/buildkite/builds/kb-n2-4-dc7fe0c49571bfef/elastic/kibana-on-merge/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

First failure: CI Build - 7.17
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jan 3, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 3, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 7.17

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 7.17

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 7.17

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 7.17

@jbudz
Copy link
Member

jbudz commented Jan 3, 2023

/skip

@kibanamachine
Copy link
Contributor Author

Skipped

7.17: edf5730

kibanamachine added a commit that referenced this issue Jan 3, 2023
@kibanamachine
skip failing test suite (#148313)
edf5730
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 7.17

@dmlemeshko dmlemeshko added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jan 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 4, 2023
@rudolf
Copy link
Contributor

rudolf commented Aug 3, 2023

Related failure on 8.x #110938

@afharo afharo self-assigned this Aug 7, 2023
@afharo afharo linked a pull request Aug 7, 2023 that will close this issue
[Flaky #110938] License updates #163286
Closed
@afharo
Copy link
Member

afharo commented Aug 10, 2023

Fixed by #163199

@afharo afharo closed this as completed Aug 10, 2023
@afharo afharo mentioned this issue Aug 10, 2023
Merged
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine kibanamachine reopened this Mar 16, 2024
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.14

@afharo
Copy link
Member

afharo commented May 6, 2024

The test's scenario.waitForPluginToDetectLicenseUpdate() only applies a delay 😅

kibana/x-pack/test/licensing_plugin/scenario.ts

Lines 111 to 115 in ea57cae

async waitForPluginToDetectLicenseUpdate() {
// > --xpack.licensing.api_polling_frequency set in test config
// to wait for Kibana server to re-fetch the license from Elasticsearch
await delay(500);
},

I'll try to work out a better way to identify that the plugin detected a license update.

afharo added a commit to afharo/kibana that referenced this issue May 6, 2024
@afharo
Fix flaky licensing test elastic#148313
4f85248
@afharo afharo mentioned this issue May 6, 2024
Merged
2 tasks
afharo added a commit that referenced this issue May 6, 2024
@afharo
Fix flaky licensing test #148313 (#182712)
6740ffb
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue May 6, 2024
@afharo
Fix flaky licensing test elastic#148313 (elastic#182712)
e2642d9 
(cherry picked from commit 6740ffb)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue May 6, 2024
@afharo
Fix flaky licensing test elastic#148313 (elastic#182712)
1032198 
(cherry picked from commit 6740ffb)
kibanamachine added a commit that referenced this issue May 6, 2024
@kibanamachine @afharo
[8.14] Fix flaky licensing test #148313 (#182712) (#182747)
4cdf84a 
# Backport

This will backport the following commits from `main` to `8.14`:
- [Fix flaky licensing test #148313
(#182712)](#182712)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-05-06T19:25:25Z","message":"Fix
flaky licensing test #148313
(#182712)","sha":"6740ffb8761097a35dd9be7b353fff33eef3d0da","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","backport:all-open","v8.15.0"],"title":"Fix
flaky licensing test
#148313","number":182712,"url":"https://github.com/elastic/kibana/pull/182712","mergeCommit":{"message":"Fix
flaky licensing test #148313
(#182712)","sha":"6740ffb8761097a35dd9be7b353fff33eef3d0da"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182712","number":182712,"mergeCommit":{"message":"Fix
flaky licensing test #148313
(#182712)","sha":"6740ffb8761097a35dd9be7b353fff33eef3d0da"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <[email protected]>
kibanamachine added a commit that referenced this issue May 6, 2024
@kibanamachine @afharo
[7.17] Fix flaky licensing test #148313 (#182712) (#182746)
0dadb78 
# Backport

This will backport the following commits from `main` to `7.17`:
- [Fix flaky licensing test #148313
(#182712)](#182712)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-05-06T19:25:25Z","message":"Fix
flaky licensing test #148313
(#182712)","sha":"6740ffb8761097a35dd9be7b353fff33eef3d0da","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","backport:all-open","v8.15.0"],"title":"Fix
flaky licensing test
#148313","number":182712,"url":"https://github.com/elastic/kibana/pull/182712","mergeCommit":{"message":"Fix
flaky licensing test #148313
(#182712)","sha":"6740ffb8761097a35dd9be7b353fff33eef3d0da"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182712","number":182712,"mergeCommit":{"message":"Fix
flaky licensing test #148313
(#182712)","sha":"6740ffb8761097a35dd9be7b353fff33eef3d0da"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <[email protected]>
@szaffarano szaffarano mentioned this issue Jul 12, 2024
Closed
adelisle pushed a commit to Makila-AI/kibana that referenced this issue Aug 5, 2024
@kibanamachine @afharo @adelisle
[7.17] Fix flaky licensing test elastic#148313 (elastic#182712) (elas…
c461516 
…tic#182746)

# Backport

This will backport the following commits from `main` to `7.17`:
- [Fix flaky licensing test elastic#148313
(elastic#182712)](elastic#182712)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-05-06T19:25:25Z","message":"Fix
flaky licensing test elastic#148313
(elastic#182712)","sha":"6740ffb8761097a35dd9be7b353fff33eef3d0da","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","backport:all-open","v8.15.0"],"title":"Fix
flaky licensing test
elastic#148313","number":182712,"url":"https://github.com/elastic/kibana/pull/182712","mergeCommit":{"message":"Fix
flaky licensing test elastic#148313
(elastic#182712)","sha":"6740ffb8761097a35dd9be7b353fff33eef3d0da"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182712","number":182712,"mergeCommit":{"message":"Fix
flaky licensing test elastic#148313
(elastic#182712)","sha":"6740ffb8761097a35dd9be7b353fff33eef3d0da"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afharo afharo

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky licensing test #148313 afharo/kibana
[Flaky #110938] License updates afharo/kibana
6 participants
@rudolf @jbudz @afharo @dmlemeshko @elasticmachine @kibanamachine