Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UnifiedFieldList] Add examples of field list #147885

Closed
Tracked by #137779
jughosta opened this issue Dec 20, 2022 · 2 comments · Fixed by #158377
Closed
Tracked by #137779

[UnifiedFieldList] Add examples of field list #147885

jughosta opened this issue Dec 20, 2022 · 2 comments · Fixed by #158377
Assignees
@jughosta
Labels
Feature:UnifiedFieldList The unified field list component used by Lens & Discover impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@jughosta
Copy link
Contributor

jughosta commented Dec 20, 2022 •
edited
Loading

Part of #137779

Examples for:

  • field list
  • field popover
  • also field stats separately
@jughosta jughosta added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:UnifiedFieldList The unified field list component used by Lens & Discover labels Dec 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@jughosta jughosta mentioned this issue Dec 20, 2022
Closed
31 tasks
@jughosta
Copy link
Contributor Author

jughosta commented Feb 16, 2023 •
edited
Loading

I think we should better create Kibana examples for it. Also add functional tests and a service for interacting with the unified field list.

@davismcphee davismcphee added the loe:needs-research This issue requires some research before it can be worked on or estimated label Feb 16, 2023
@jughosta jughosta changed the title [UnifiedFieldList] Add examples of field list to storybook [UnifiedFieldList] Add examples of field list May 3, 2023
@jughosta jughosta mentioned this issue May 26, 2023
Merged
1 task
jughosta added a commit that referenced this issue May 31, 2023
@jughosta @kibanamachine
[UnifiedFieldList] Remove redundant server routes. Create new example…
8d399fe 
… plugin for unified field list components and migrate tests. (#158377)

- Closes #147885
- Closes #157109

## Summary

**Before:**

Unified Field List plugin has internal routes (wrappers for client code)
which exist only to run api functional tests against them:
 - `/api/unified_field_list/existing_fields/{dataViewId}`
 - `/api/unified_field_list/field_stats`

Client code does not call these routes directly. So there is no reason
in keeping and versioning them.

**After:**
- Internal routes are removed 
- A new "Unified Field List Examples" page was created
http://localhost:5601/app/unifiedFieldListExamples
- API functional tests (which used the routes) were converted to
functional tests against this new example page
- Created a new `unifiedFieldList` page object which is used now in
functional tests (methods are extracted from existing `discover` page
object).

**For testing:**

Steps:
1. Run Kibana with examples: `yarn start --run-examples` 
2. Install sample data
3. And navigate to Developer Examples > Unified Field List Examples
page.

![May-26-2023
13-24-03](https://github.com/elastic/kibana/assets/1415710/5a2149f7-beb8-40a5-b7d5-9eeaabfd42ca)


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
Feature:UnifiedFieldList The unified field list component used by Lens & Discover impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
3 participants
@jughosta @elasticmachine @davismcphee