Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird semicolon during loading #146342

Closed
maretodoric opened this issue Nov 25, 2022 · 4 comments · Fixed by #146500
Closed

Weird semicolon during loading #146342

maretodoric opened this issue Nov 25, 2022 · 4 comments · Fixed by #146500
Assignees
@miltonhultgren
Labels
bug Fixes for quality problems that affect the customer experience Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@maretodoric
Copy link

Kibana version:
8.5.2

Elasticsearch version:
8.5.2

Server OS version:
Ubuntu 20.04

Browser version:
Google Chrome 107

Browser OS version:
Android 12, MIUI 13.0.4

Original install method (e.g. download page, yum, from source, etc.):
apt repo

Describe the bug:
When visiting kibana/app/monitoring endpoint (Sandwich menu -> Management -> Stack Monitoring), there is a weird semicolon at the bottom BEFORE loading spinner is removed and content is loaded

Steps to reproduce:

  1. Visit Sandwich menu -> Management -> Stack Monitoring on Android phone (haven't noticed on PC but might've missed me)
  2. Look at the bottom left before loading completes

Expected behavior:
Should not be there

Screenshots (if relevant):
IMG_20221125_094825

Errors in browser console (if relevant):
None

Provide logs and/or server output (if relevant):
This was visible on previous versions, too.

Any additional context:
@maretodoric maretodoric added the bug Fixes for quality problems that affect the customer experience label Nov 25, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 25, 2022
@dmlemeshko
Copy link
Member

Hi @maretodoric ,

Thank you for reporting. I'm not able to reproduce it in chrome simulation. Could you double check it in your PC browser or other mobile device?

Thanks

@maretodoric
Copy link
Author

maretodoric commented Nov 25, 2022 •
edited
Loading

Hello @dmlemeshko ,

thanks for replying so quickly.
It's there for a brief time, just checked on PC as well. I've also tested on an older cluster with version 8.4.2, it also shows semicolon. Tested on 3 different phones, Xiaomi Redmi Note 11 Pro+ 5G (Android 12), Redmi Note 8 Pro (Android 11), Samsung Galaxy A32 (Android 12)
But again, only for a brief time.

I've found this out when my cluster state was red and kibana had issues accessing the data due to high load. It took a while for everything to load but once it loaded, semicolon was gone.

I could replicate this by simulating poor network environment. For example in firefox, developer tools, Network tab, I've changed from "No Throttling" to "Regular 2G" (GPRS was too slow, never seems to get pass "Loading Elastic" logo to get to the page where semicolon is displayed).

If you try to emulate regular 2g, you might be able to see the semicolon before it disappears. You can prepare browser search for ';' and just tap F3 until it gets highlighted.
Here a screenshot from Mozilla Firefox browser showing this on cluster with 8.4.2. It's same for 8.5.2.

image

@bhavyarm bhavyarm added Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Nov 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 28, 2022
@miltonhultgren miltonhultgren self-assigned this Nov 29, 2022
@miltonhultgren miltonhultgren mentioned this issue Nov 29, 2022
Merged
@miltonhultgren
Copy link
Contributor

Thanks for reporting this, I opened a PR to fix it!

miltonhultgren added a commit that referenced this issue Nov 29, 2022
@miltonhultgren
[Stack Monitoring] Remove visible semicolon from LoadingPage (#146500)
5c13741 
Fixes #146342

There was a semicolon added to the JSX markup which would show on slower
devices where loading takes longer.
Please refer to the issue for a screenshot of that.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 29, 2022
@miltonhultgren
[Stack Monitoring] Remove visible semicolon from LoadingPage (elastic…
7ef7f98 
…#146500)

Fixes elastic#146342

There was a semicolon added to the JSX markup which would show on slower
devices where loading takes longer.
Please refer to the issue for a screenshot of that.

(cherry picked from commit 5c13741)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 29, 2022
@miltonhultgren
[Stack Monitoring] Remove visible semicolon from LoadingPage (elastic…
bdf92fc 
…#146500)

Fixes elastic#146342

There was a semicolon added to the JSX markup which would show on slower
devices where loading takes longer.
Please refer to the issue for a screenshot of that.

(cherry picked from commit 5c13741)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 29, 2022
@miltonhultgren
[Stack Monitoring] Remove visible semicolon from LoadingPage (elastic…
81ade72 
…#146500)

Fixes elastic#146342

There was a semicolon added to the JSX markup which would show on slower
devices where loading takes longer.
Please refer to the issue for a screenshot of that.

(cherry picked from commit 5c13741)
kibanamachine added a commit that referenced this issue Nov 29, 2022
@kibanamachine @miltonhultgren
[8.5] [Stack Monitoring] Remove visible semicolon from LoadingPage (#…
9be55d5 
…146500) (#146505)

# Backport

This will backport the following commits from `main` to `8.5`:
- [[Stack Monitoring] Remove visible semicolon from LoadingPage
(#146500)](#146500)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Milton
Hultgren","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-29T09:17:29Z","message":"[Stack
Monitoring] Remove visible semicolon from LoadingPage (#146500)\n\nFixes
#146342\r\n\r\nThere was a semicolon added to the JSX markup which would
show on slower\r\ndevices where loading takes longer.\r\nPlease refer to
the issue for a screenshot of
that.","sha":"5c13741663fdc750adad0df28330e0a226dc11a8","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra
Monitoring UI","release_note:skip","Feature:Stack
Monitoring","backport:all-open","v8.7.0"],"number":146500,"url":"https://github.com/elastic/kibana/pull/146500","mergeCommit":{"message":"[Stack
Monitoring] Remove visible semicolon from LoadingPage (#146500)\n\nFixes
#146342\r\n\r\nThere was a semicolon added to the JSX markup which would
show on slower\r\ndevices where loading takes longer.\r\nPlease refer to
the issue for a screenshot of
that.","sha":"5c13741663fdc750adad0df28330e0a226dc11a8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146500","number":146500,"mergeCommit":{"message":"[Stack
Monitoring] Remove visible semicolon from LoadingPage (#146500)\n\nFixes
#146342\r\n\r\nThere was a semicolon added to the JSX markup which would
show on slower\r\ndevices where loading takes longer.\r\nPlease refer to
the issue for a screenshot of
that.","sha":"5c13741663fdc750adad0df28330e0a226dc11a8"}}]}] BACKPORT-->

Co-authored-by: Milton Hultgren <[email protected]>
kibanamachine added a commit that referenced this issue Nov 29, 2022
@kibanamachine @miltonhultgren
[7.17] [Stack Monitoring] Remove visible semicolon from LoadingPage (#…
ebb132c 
…146500) (#146504)

# Backport

This will backport the following commits from `main` to `7.17`:
- [[Stack Monitoring] Remove visible semicolon from LoadingPage
(#146500)](#146500)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Milton
Hultgren","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-29T09:17:29Z","message":"[Stack
Monitoring] Remove visible semicolon from LoadingPage (#146500)\n\nFixes
#146342\r\n\r\nThere was a semicolon added to the JSX markup which would
show on slower\r\ndevices where loading takes longer.\r\nPlease refer to
the issue for a screenshot of
that.","sha":"5c13741663fdc750adad0df28330e0a226dc11a8","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra
Monitoring UI","release_note:skip","Feature:Stack
Monitoring","backport:all-open","v8.7.0"],"number":146500,"url":"https://github.com/elastic/kibana/pull/146500","mergeCommit":{"message":"[Stack
Monitoring] Remove visible semicolon from LoadingPage (#146500)\n\nFixes
#146342\r\n\r\nThere was a semicolon added to the JSX markup which would
show on slower\r\ndevices where loading takes longer.\r\nPlease refer to
the issue for a screenshot of
that.","sha":"5c13741663fdc750adad0df28330e0a226dc11a8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146500","number":146500,"mergeCommit":{"message":"[Stack
Monitoring] Remove visible semicolon from LoadingPage (#146500)\n\nFixes
#146342\r\n\r\nThere was a semicolon added to the JSX markup which would
show on slower\r\ndevices where loading takes longer.\r\nPlease refer to
the issue for a screenshot of
that.","sha":"5c13741663fdc750adad0df28330e0a226dc11a8"}}]}] BACKPORT-->

Co-authored-by: Milton Hultgren <[email protected]>
kibanamachine added a commit that referenced this issue Nov 29, 2022
@kibanamachine @miltonhultgren
[8.6] [Stack Monitoring] Remove visible semicolon from LoadingPage (#…
85e6fc5 
…146500) (#146506)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Stack Monitoring] Remove visible semicolon from LoadingPage
(#146500)](#146500)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Milton
Hultgren","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-29T09:17:29Z","message":"[Stack
Monitoring] Remove visible semicolon from LoadingPage (#146500)\n\nFixes
#146342\r\n\r\nThere was a semicolon added to the JSX markup which would
show on slower\r\ndevices where loading takes longer.\r\nPlease refer to
the issue for a screenshot of
that.","sha":"5c13741663fdc750adad0df28330e0a226dc11a8","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra
Monitoring UI","release_note:skip","Feature:Stack
Monitoring","backport:all-open","v8.7.0"],"number":146500,"url":"https://github.com/elastic/kibana/pull/146500","mergeCommit":{"message":"[Stack
Monitoring] Remove visible semicolon from LoadingPage (#146500)\n\nFixes
#146342\r\n\r\nThere was a semicolon added to the JSX markup which would
show on slower\r\ndevices where loading takes longer.\r\nPlease refer to
the issue for a screenshot of
that.","sha":"5c13741663fdc750adad0df28330e0a226dc11a8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146500","number":146500,"mergeCommit":{"message":"[Stack
Monitoring] Remove visible semicolon from LoadingPage (#146500)\n\nFixes
#146342\r\n\r\nThere was a semicolon added to the JSX markup which would
show on slower\r\ndevices where loading takes longer.\r\nPlease refer to
the issue for a screenshot of
that.","sha":"5c13741663fdc750adad0df28330e0a226dc11a8"}}]}] BACKPORT-->

Co-authored-by: Milton Hultgren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miltonhultgren miltonhultgren

Labels
bug Fixes for quality problems that affect the customer experience Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Stack Monitoring] Remove visible semicolon from LoadingPage miltonhultgren/kibana
5 participants
@miltonhultgren @bhavyarm @dmlemeshko @elasticmachine @maretodoric