Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Observability Alert Search Bar in APM Alerts tab #146290

Closed
1 task done
Tracked by #137205 ...
maryam-saeidi opened this issue Nov 24, 2022 · 3 comments · Fixed by #149610
Closed
1 task done
Tracked by #137205 ...

Integrate Observability Alert Search Bar in APM Alerts tab #146290

maryam-saeidi opened this issue Nov 24, 2022 · 3 comments · Fixed by #149610
Assignees
Labels
apm:alerting apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.7.0

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Nov 24, 2022

📝 Summary

After completion of #146286, the APM team can use the new shared Alert Search Bar and integrate it into the Alerts tab in the APM app.

By doing so, there is no need for custom AlertsTableStatusFilter component as it will be provided by the new shared Alert Search Bar (in the future, it will be replaced with controls as proposed by unified search)

The same component was used on the Alerts and Rule details pages, the tab will look like this:

image

Note

After this integration, we will be able to integrate the Alert Summary Widget component in APM, and upon clicking on the widget, we send the user to the Alerts tab with the correct filtering. (So it is important to be able to apply the same filter on the alert's tab)

You can integrate the search bar as mentioned in the how to test section of this PR.

Prerequisite

✅ Acceptance Criteria

  • Integrate the new Alert Search Bar
  • Implement the possibility of landing on this tab and applying the time range and KQL filters as provided (for example by loading them from the URL query params) --> This functionality will be used in the Alert Summary Widget
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 24, 2022
@maryam-saeidi maryam-saeidi added the Team:APM All issues that need APM UI Team support label Nov 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@maryam-saeidi
Copy link
Member Author

@gbamparop I merged my PR, so this ticket can be picked up.

@sorenlouv sorenlouv removed the blocked label Dec 15, 2022
@sorenlouv
Copy link
Member

Thanks for the heads up @maryam-saeidi . With many people out on PTO it is doubtful if we'll get this into 8.7. We'll have a better overview in the beginning of January.

@kpatticha kpatticha self-assigned this Jan 25, 2023
kpatticha added a commit that referenced this issue Jan 27, 2023
## Summary

Closes: #146290

- Integrate Alert search bar
- Delete alerts status filters as it comes for free with the search bar
- Respect time range when fetching alert counts on service inventory and
service overview page
- as the search bar now supports time ranges, it's required to display
consistent data.

### Before 


![image](https://user-images.githubusercontent.com/3369346/214894397-6850274f-f701-481a-a12c-688c144f4c32.png)



### After


https://user-images.githubusercontent.com/3369346/214894788-5fcd42e2-b48f-434f-b38d-18579bfc280e.mov


TODO
- [x]
[getServiceAlerts](https://github.com/elastic/kibana/pull/149610/files#diff-82ef341af674bd7f203551b4d75b73d221a49e6ae4169e0c396e96abb04902bcR59-R67
) query doesn't include environment while the table respects that
filter. Check what's the correct way.

---------

Co-authored-by: kibanamachine <[email protected]>
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this issue Feb 6, 2023
## Summary

Closes: elastic#146290

- Integrate Alert search bar
- Delete alerts status filters as it comes for free with the search bar
- Respect time range when fetching alert counts on service inventory and
service overview page
- as the search bar now supports time ranges, it's required to display
consistent data.

### Before 


![image](https://user-images.githubusercontent.com/3369346/214894397-6850274f-f701-481a-a12c-688c144f4c32.png)



### After


https://user-images.githubusercontent.com/3369346/214894788-5fcd42e2-b48f-434f-b38d-18579bfc280e.mov


TODO
- [x]
[getServiceAlerts](https://github.com/elastic/kibana/pull/149610/files#diff-82ef341af674bd7f203551b4d75b73d221a49e6ae4169e0c396e96abb04902bcR59-R67
) query doesn't include environment while the table respects that
filter. Check what's the correct way.

---------

Co-authored-by: kibanamachine <[email protected]>
@kpatticha kpatticha added the apm:test-plan-done Pull request that was successfully tested during the test plan label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:alerting apm:test-plan-done Pull request that was successfully tested during the test plan Team:APM All issues that need APM UI Team support v8.7.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants