-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Observability Alert Search Bar in APM Alerts tab #146290
Closed
1 task done
Labels
apm:alerting
apm:test-plan-done
Pull request that was successfully tested during the test plan
Team:APM
All issues that need APM UI Team support
v8.7.0
Comments
Pinging @elastic/apm-ui (Team:APM) |
2 tasks
@gbamparop I merged my PR, so this ticket can be picked up. |
Thanks for the heads up @maryam-saeidi . With many people out on PTO it is doubtful if we'll get this into 8.7. We'll have a better overview in the beginning of January. |
1 task
1 task
kpatticha
added a commit
that referenced
this issue
Jan 27, 2023
## Summary Closes: #146290 - Integrate Alert search bar - Delete alerts status filters as it comes for free with the search bar - Respect time range when fetching alert counts on service inventory and service overview page - as the search bar now supports time ranges, it's required to display consistent data. ### Before ![image](https://user-images.githubusercontent.com/3369346/214894397-6850274f-f701-481a-a12c-688c144f4c32.png) ### After https://user-images.githubusercontent.com/3369346/214894788-5fcd42e2-b48f-434f-b38d-18579bfc280e.mov TODO - [x] [getServiceAlerts](https://github.com/elastic/kibana/pull/149610/files#diff-82ef341af674bd7f203551b4d75b73d221a49e6ae4169e0c396e96abb04902bcR59-R67 ) query doesn't include environment while the table respects that filter. Check what's the correct way. --------- Co-authored-by: kibanamachine <[email protected]>
kqualters-elastic
pushed a commit
to kqualters-elastic/kibana
that referenced
this issue
Feb 6, 2023
## Summary Closes: elastic#146290 - Integrate Alert search bar - Delete alerts status filters as it comes for free with the search bar - Respect time range when fetching alert counts on service inventory and service overview page - as the search bar now supports time ranges, it's required to display consistent data. ### Before ![image](https://user-images.githubusercontent.com/3369346/214894397-6850274f-f701-481a-a12c-688c144f4c32.png) ### After https://user-images.githubusercontent.com/3369346/214894788-5fcd42e2-b48f-434f-b38d-18579bfc280e.mov TODO - [x] [getServiceAlerts](https://github.com/elastic/kibana/pull/149610/files#diff-82ef341af674bd7f203551b4d75b73d221a49e6ae4169e0c396e96abb04902bcR59-R67 ) query doesn't include environment while the table respects that filter. Check what's the correct way. --------- Co-authored-by: kibanamachine <[email protected]>
kpatticha
added
the
apm:test-plan-done
Pull request that was successfully tested during the test plan
label
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
apm:alerting
apm:test-plan-done
Pull request that was successfully tested during the test plan
Team:APM
All issues that need APM UI Team support
v8.7.0
📝 Summary
After completion of #146286, the APM team can use the new shared Alert Search Bar and integrate it into the Alerts tab in the APM app.
By doing so, there is no need for custom
AlertsTableStatusFilter
component as it will be provided by the new shared Alert Search Bar (in the future, it will be replaced with controls as proposed by unified search)The same component was used on the Alerts and Rule details pages, the tab will look like this:
Note
After this integration, we will be able to integrate the Alert Summary Widget component in APM, and upon clicking on the widget, we send the user to the Alerts tab with the correct filtering. (So it is important to be able to apply the same filter on the alert's tab)
You can integrate the search bar as mentioned in the
how to test
section of this PR.Prerequisite
✅ Acceptance Criteria
The text was updated successfully, but these errors were encountered: