Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Rule type title in create rule flyout with huge font-size #145999

Closed
jcger opened this issue Nov 22, 2022 · 5 comments · Fixed by #147001
Closed

[RAM] Rule type title in create rule flyout with huge font-size #145999

jcger opened this issue Nov 22, 2022 · 5 comments · Fixed by #147001
Assignees
@jcger
Labels
bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@jcger
Copy link
Contributor

jcger commented Nov 22, 2022 •
edited
Loading

Kibana version:
8.7

Describe the bug:
Rule types with huge font-size in create rule flyout

Steps to reproduce:

  1. Go to Stack Management > Stack Rules
  2. Click on "Create rule"

Expected behavior:
I would expect the rule type titles have a smaller font

Screenshots (if relevant):
Screenshot 2022-11-21 at 12 08 13

Errors in browser console (if relevant):
None
@jcger jcger added bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Nov 22, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@XavierM
Copy link
Contributor

XavierM commented Nov 22, 2022

@mdefazio what do you think?

@mdefazio
Copy link
Contributor

@jcger I was not able to reproduce this. I am seeing a 16px font size. You are correct though, it should not be that large—the 16px size is the correct one.

image

@jcger
Copy link
Contributor Author

jcger commented Nov 28, 2022

Hi @mdefazio, which kibana version and browser are you using? I tried again and I'm still this oversized font size in the main branch using safari and chrome

@mdefazio
Copy link
Contributor

@jcger nm...was on 8.7, but not most recent changes on main. I am now seeing what you're seeing. The correct font size should be 16px.

@jcger jcger moved this from Awaiting Triage to In Progress in AppEx: ResponseOps - Rules & Alerts Management Dec 5, 2022
@jcger jcger self-assigned this Dec 5, 2022
@jcger jcger mentioned this issue Dec 5, 2022
Merged
@jcger jcger moved this from In Progress to In Review in AppEx: ResponseOps - Rules & Alerts Management Dec 5, 2022
jcger added a commit that referenced this issue Dec 5, 2022
@jcger
[RAM] fix create rule titles font-size (#147001)
c7bd2ff 
## Summary

Closes #145999

Screenshot with applied changes:

![Screenshot 2022-12-05 at 15 23
21](https://user-images.githubusercontent.com/17549662/205660619-137f01c9-673a-468a-8a00-e8253c60d9cd.png)
Repository owner moved this from In Review to Done in AppEx: ResponseOps - Rules & Alerts Management Dec 5, 2022
@maryam-saeidi maryam-saeidi mentioned this issue Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcger jcger

Labels
bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RAM] fix create rule titles font-size jcger/kibana
4 participants
@XavierM @mdefazio @elasticmachine @jcger