Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/cases/deletion·ts - Cases cases deletion sub privilege create two cases logging in with user cases_all_user "before each" hook for "User cases_all_user can delete a case using the row actions" #145271

Closed
kibanamachine opened this issue Nov 15, 2022 · 7 comments · Fixed by #150117
Closed

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/cases/deletion·ts - Cases cases deletion sub privilege create two cases logging in with user cases_all_user "before each" hook for "User cases_all_user can delete a case using the row actions" #145271

kibanamachine opened this issue Nov 15, 2022 · 7 comments · Fixed by #150117
Assignees
@jonathan-buttner
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 15, 2022 •
edited
Loading

A test failed on a tracked branch

Error: timed out waiting for cases to appear on the all cases table
    at onFailure (node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry_for_truthy.js:34:13)
    at retryForSuccess (node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry_for_success.js:55:13)
    at retryForTruthy (node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry_for_truthy.js:24:3)
    at RetryService.waitFor (node_modules/@kbn/ftr-common-functional-services/target_node/services/retry/retry.js:52:5)
    at Object.waitForCasesToBeListed (x-pack/test/functional/services/cases/list.ts:99:7)
    at navigateToCasesAndWaitToLoad (x-pack/test/functional_with_es_ssl/apps/cases/deletion.ts:128:3)
    at Context.<anonymous> (x-pack/test/functional_with_es_ssl/apps/cases/deletion.ts:48:13)
    at Object.apply (node_modules/@kbn/test/target_node/src/functional_test_runner/lib/mocha/wrap_function.js:78:16)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Nov 15, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 15, 2022
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Nov 15, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 15, 2022
@cnasikas cnasikas added the Feature:Cases Cases feature label Nov 16, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@jbudz
Copy link
Member

jbudz commented Nov 18, 2022

/skip

@kibanamachine
Copy link
Contributor Author

Skipped

main: 0b6de4b

kibanamachine added a commit that referenced this issue Nov 18, 2022
@kibanamachine
skip failing test suite (#145271)
0b6de4b
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.6

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.6

mistic pushed a commit that referenced this issue Nov 30, 2022
@kibanamachine @mistic
skip failing test suite (#145271)
0b43f5f
@mistic mistic added the v8.6.1 label Nov 30, 2022
@jonathan-buttner jonathan-buttner self-assigned this Jan 10, 2023
@jonathan-buttner jonathan-buttner mentioned this issue Feb 1, 2023
Merged
jonathan-buttner added a commit that referenced this issue Feb 6, 2023
@jonathan-buttner
[Cases] Improve functional tests (#150117)
c3ea5e5 
This PR tries to improve how often our functional tests succeeds. I also
tried cleaning up a few things that seemed to be slowing the tests down
and also causing errors when the tests were run individually.

Fixes: #145271

Notable changes:
- I added a value to the `property-actions*` in most places so that the
functional tests can distinguish between a description, comment, or the
case ellipses this seems to work consistently where other methods have
not

Flaky test run:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1871
jonathan-buttner added a commit to jonathan-buttner/kibana that referenced this issue Feb 7, 2023
@jonathan-buttner
[Cases] Improve functional tests (elastic#150117)
549428c 
This PR tries to improve how often our functional tests succeeds. I also
tried cleaning up a few things that seemed to be slowing the tests down
and also causing errors when the tests were run individually.

Fixes: elastic#145271

Notable changes:
- I added a value to the `property-actions*` in most places so that the
functional tests can distinguish between a description, comment, or the
case ellipses this seems to work consistently where other methods have
not

Flaky test run:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1871

(cherry picked from commit c3ea5e5)

# Conflicts:
#	x-pack/plugins/cases/public/components/case_action_bar/actions.test.tsx
#	x-pack/plugins/cases/public/components/case_action_bar/index.test.tsx
#	x-pack/plugins/cases/public/components/property_actions/index.tsx
#	x-pack/plugins/cases/public/components/user_actions/index.test.tsx
#	x-pack/test/functional_with_es_ssl/apps/cases/view_case.ts
jonathan-buttner referenced this issue Feb 7, 2023
@jonathan-buttner
[8.6] [Cases] Improve functional tests (#150117) (#150454)
940700a 
# Backport

This will backport the following commits from `main` to `8.6`:
- [[Cases] Improve functional tests
(#150117)](#150117)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jonathan
Buttner","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-06T20:38:36Z","message":"[Cases]
Improve functional tests (#150117)\n\nThis PR tries to improve how often
our functional tests succeeds. I also\r\ntried cleaning up a few things
that seemed to be slowing the tests down\r\nand also causing errors when
the tests were run individually.\r\n\r\nFixes:
https://github.com/elastic/kibana/issues/145271\r\n\r\nNotable
changes:\r\n- I added a value to the `property-actions*` in most places
so that the\r\nfunctional tests can distinguish between a description,
comment, or the\r\ncase ellipses this seems to work consistently where
other methods have\r\nnot\r\n\r\nFlaky test
run:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1871","sha":"c3ea5e5b3a2f0e13e743eea059404c81a07576c1","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:ResponseOps","Feature:Cases","v8.7.0"],"number":150117,"url":"https://github.com/elastic/kibana/pull/150117","mergeCommit":{"message":"[Cases]
Improve functional tests (#150117)\n\nThis PR tries to improve how often
our functional tests succeeds. I also\r\ntried cleaning up a few things
that seemed to be slowing the tests down\r\nand also causing errors when
the tests were run individually.\r\n\r\nFixes:
https://github.com/elastic/kibana/issues/145271\r\n\r\nNotable
changes:\r\n- I added a value to the `property-actions*` in most places
so that the\r\nfunctional tests can distinguish between a description,
comment, or the\r\ncase ellipses this seems to work consistently where
other methods have\r\nnot\r\n\r\nFlaky test
run:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1871","sha":"c3ea5e5b3a2f0e13e743eea059404c81a07576c1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150117","number":150117,"mergeCommit":{"message":"[Cases]
Improve functional tests (#150117)\n\nThis PR tries to improve how often
our functional tests succeeds. I also\r\ntried cleaning up a few things
that seemed to be slowing the tests down\r\nand also causing errors when
the tests were run individually.\r\n\r\nFixes:
https://github.com/elastic/kibana/issues/145271\r\n\r\nNotable
changes:\r\n- I added a value to the `property-actions*` in most places
so that the\r\nfunctional tests can distinguish between a description,
comment, or the\r\ncase ellipses this seems to work consistently where
other methods have\r\nnot\r\n\r\nFlaky test
run:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1871","sha":"c3ea5e5b3a2f0e13e743eea059404c81a07576c1"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathan-buttner jonathan-buttner

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Cases] Improve functional tests jonathan-buttner/kibana
6 participants
@jbudz @mistic @cnasikas @elasticmachine @kibanamachine @jonathan-buttner