Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Anomaly detection job list refresh button broken #144529

Closed
jgowdyelastic opened this issue Nov 3, 2022 · 2 comments · Fixed by #145757
Closed

[ML] Anomaly detection job list refresh button broken #144529

jgowdyelastic opened this issue Nov 3, 2022 · 2 comments · Fixed by #145757
Assignees
@jgowdyelastic
Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml Team:ML Team label for ML (also use :ml) v8.6.0

Comments

@jgowdyelastic
Copy link
Member

The refresh button at the top of the page only works when auto refresh is enabled.
@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection v8.6.0 labels Nov 3, 2022
@jgowdyelastic jgowdyelastic self-assigned this Nov 3, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 3, 2022
@nickpeihl nickpeihl added :ml Team:ML Team label for ML (also use :ml) labels Nov 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 9, 2022
@jgowdyelastic
Copy link
Member Author

jgowdyelastic commented Nov 14, 2022 •
edited
Loading

Update, the button is only broken immediately after toggling the auto refresh off.
image

If you reload the page, the refresh button works again but and auto refresh remains switched off.

@jgowdyelastic jgowdyelastic mentioned this issue Nov 18, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 22, 2022
@jgowdyelastic
[ML] Fix anomaly detection jobs list not refreshing (elastic#145757)
f1d7095 
Fixes elastic#144529

Removes the `blockRefresh` prop which is no longer needed since the page
refresh controls trigger a whole re-render of the `JobsPage` component.

(cherry picked from commit c520869)
kibanamachine referenced this issue Nov 22, 2022
@kibanamachine @jgowdyelastic
[8.6] [ML] Fix anomaly detection jobs list not refreshing (#145757) (#…
6dfa1dd 
…145971)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[ML] Fix anomaly detection jobs list not refreshing
(#145757)](#145757)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-22T10:53:18Z","message":"[ML]
Fix anomaly detection jobs list not refreshing (#145757)\n\nFixes
https://github.com/elastic/kibana/issues/144529\r\n\r\nRemoves the
`blockRefresh` prop which is no longer needed since the page\r\nrefresh
controls trigger a whole re-render of the `JobsPage`
component.","sha":"c5208695a9fc7c88de781500179864141ca99098","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix",":ml","Feature:Anomaly
Detection","v8.6.0","v8.7.0"],"number":145757,"url":"https://github.com/elastic/kibana/pull/145757","mergeCommit":{"message":"[ML]
Fix anomaly detection jobs list not refreshing (#145757)\n\nFixes
https://github.com/elastic/kibana/issues/144529\r\n\r\nRemoves the
`blockRefresh` prop which is no longer needed since the page\r\nrefresh
controls trigger a whole re-render of the `JobsPage`
component.","sha":"c5208695a9fc7c88de781500179864141ca99098"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145757","number":145757,"mergeCommit":{"message":"[ML]
Fix anomaly detection jobs list not refreshing (#145757)\n\nFixes
https://github.com/elastic/kibana/issues/144529\r\n\r\nRemoves the
`blockRefresh` prop which is no longer needed since the page\r\nrefresh
controls trigger a whole re-render of the `JobsPage`
component.","sha":"c5208695a9fc7c88de781500179864141ca99098"}}]}]
BACKPORT-->

Co-authored-by: James Gowdy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgowdyelastic jgowdyelastic

Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml Team:ML Team label for ML (also use :ml) v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ML] Fix anomaly detection jobs list not refreshing jgowdyelastic/kibana
3 participants
@nickpeihl @elasticmachine @jgowdyelastic