Monitoring time picker changes should not be implemented in multiple locations #14190
Labels
chore
Feature:Visualizations
Generic visualization features (in case no more specific feature label is available)
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
We have multiple locations where we monitor changes in the time-picker. This should be consolidated in the timepicker itself
From #12811 (comment):
Responding to changes in the time-picker is currently implemented all over the place.
https://github.com/thomasneirynck/kibana/blob/4c7022a725b9dcd4295c4c980c625a61bad86941/src/core_plugins/timelion/public/app.js#L181-L181
The reason Discover works is because it relies on courier.
Visualize - after the refactor - should have its own refresher (triggering a reload event on every tick). This should replace the refresher from TSVB (and perhaps Timelion). Alternatively, we could make this optional, so individual visualizations can opt-in/opt-out of the auto-refreshing functionality.
Also consider that this timing loop should run in the timepicker component itself (https://github.com/thomasneirynck/kibana/blob/5c075f2a3f4eb3bebd2ec7a105b5a03ff8abe292/src/ui/public/timepicker/timepicker.js#L210-L210). That way, all clients of the timepicker can listen to an auto-refresh event. Right now, this logic is flipped.
The text was updated successfully, but these errors were encountered: