Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-refresh does not work on dashboard and visualize #12811

Closed
thomasneirynck opened this issue Jul 12, 2017 · 1 comment · Fixed by #12823
Closed

Auto-refresh does not work on dashboard and visualize #12811

thomasneirynck opened this issue Jul 12, 2017 · 1 comment · Fixed by #12823
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) PR sent v6.0.0-beta1 v6.0.0

Comments

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Jul 12, 2017

On master, the auto-refresh of the time-picker does not cause a refresh on the dashboard and visualize page.

This does work properly on the Discovery page though.

@thomasneirynck thomasneirynck added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) bug Fixes for quality problems that affect the customer experience v6.0.0 v6.0.0-beta1 labels Jul 12, 2017
@thomasneirynck
Copy link
Contributor Author

This is a regression with the visualize refactor, which divorced Visualize from courier.

Responding to changes in the time-picker is currently implemented all over the place.

The reason Discover works is because it relies on courier.

Visualize - after the refactor - should have its own refresher (triggering a reload event on every tick). This should replace the refresher from TSVB (and perhaps Timelion). Alternatively, we could make this optional, so individual visualizations can opt-in/opt-out of the auto-refreshing functionality.

Also consider that this timing loop should run in the timepicker component itself (https://github.com/thomasneirynck/kibana/blob/5c075f2a3f4eb3bebd2ec7a105b5a03ff8abe292/src/ui/public/timepicker/timepicker.js#L210-L210). That way, all clients of the timepicker can listen to an auto-refresh event. Right now, this logic is flipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) PR sent v6.0.0-beta1 v6.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants