Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Validation message is displaying for a second when rule is created with saved query then edit the rule #141758

Closed
ghost opened this issue Sep 26, 2022 · 6 comments
Closed

[Security Solution] Validation message is displaying for a second when rule is created with saved query then edit the rule #141758

ghost opened this issue Sep 26, 2022 · 6 comments
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Alerts Security Detection Alerts Area Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.5.0

Comments

@ghost
Copy link

ghost commented Sep 26, 2022

Describe the bug
Validation message is displaying for a second when edit the saved query rule

Build info

VERSION: 8.5.0-BC1
COMMIT: 0d8de4df69f8084a94cdd9638d7de510813cb5ce
BUILD: 56595

Preconditions

  1. Kibana should be running
  2. Create a rule with Saved query

Steps to Reproduce

  1. Navigate to Security > Rule detail page
  2. Click on above created rule
  3. Edit the rule
  4. Observe that Validation message is displaying for a second when edit the saved query rule

Actual Result
Validation message is displaying for a second when edit the saved query rule

Expected Result
Validation message should not be displayed when edit the saved query rule

Screen-record

Rules.-.saved.query.mp4
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.5.0 labels Sep 26, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema added Team:Detections and Resp Security Detection Response Team Team:Detection Rule Management Security Detection Rule Management Team labels Sep 26, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@banderror banderror added Team:Detection Alerts Security Detection Alerts Area Team and removed Team:Detection Rule Management Security Detection Rule Management Team labels Sep 26, 2022
@banderror banderror assigned marshallmain and unassigned banderror Sep 26, 2022
@banderror
Copy link
Contributor

cc @vitaliidm

@vitaliidm vitaliidm mentioned this issue Oct 4, 2022
Merged
1 task
vitaliidm added a commit that referenced this issue Oct 10, 2022
@vitaliidm
[Detections][Alerts] fixes saved_query rule validation issue (#142602)
4feb397 
## Summary

- addresses #141758
- loads saved query on rules edit page before form rendering, thus prevents validation run on uncompleted data(saved query wasn't fetched before QueryBar component renders). Then fetched saved query passed to QueryBarDefineRule component


### Before

https://user-images.githubusercontent.com/92328789/193884969-3647e06b-085a-4923-82e8-546bedabeb3e.mp4


### After

https://user-images.githubusercontent.com/92328789/193884323-629fb879-3a51-4412-8b63-2f36afc618cb.mov


As side effect, it reduced number of requests for saved query:
#### Before
2 requests were sent
<img width="1995" alt="Screenshot 2022-10-05 at 09 39 09" src="https://user-images.githubusercontent.com/92328789/194018652-5612a032-e908-4e01-9858-2049c8e453e2.png">

#### After
Only one request sent


### Checklist
<img width="1996" alt="Screenshot 2022-10-05 at 09 37 12" src="https://user-images.githubusercontent.com/92328789/194018637-770a08df-832b-4838-a060-05058c436ed6.png">


Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 10, 2022
@vitaliidm
[Detections][Alerts] fixes saved_query rule validation issue (elastic…
04e1266 
…#142602)

## Summary

- addresses elastic#141758
- loads saved query on rules edit page before form rendering, thus prevents validation run on uncompleted data(saved query wasn't fetched before QueryBar component renders). Then fetched saved query passed to QueryBarDefineRule component

### Before

https://user-images.githubusercontent.com/92328789/193884969-3647e06b-085a-4923-82e8-546bedabeb3e.mp4

### After

https://user-images.githubusercontent.com/92328789/193884323-629fb879-3a51-4412-8b63-2f36afc618cb.mov

As side effect, it reduced number of requests for saved query:
#### Before
2 requests were sent
<img width="1995" alt="Screenshot 2022-10-05 at 09 39 09" src="https://user-images.githubusercontent.com/92328789/194018652-5612a032-e908-4e01-9858-2049c8e453e2.png">

#### After
Only one request sent

### Checklist
<img width="1996" alt="Screenshot 2022-10-05 at 09 37 12" src="https://user-images.githubusercontent.com/92328789/194018637-770a08df-832b-4838-a060-05058c436ed6.png">

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

(cherry picked from commit 4feb397)
kibanamachine added a commit that referenced this issue Oct 10, 2022
@kibanamachine @vitaliidm
[Detections][Alerts] fixes saved_query rule validation issue (#142602) (
80caa15 
#143008)

## Summary

- addresses #141758
- loads saved query on rules edit page before form rendering, thus prevents validation run on uncompleted data(saved query wasn't fetched before QueryBar component renders). Then fetched saved query passed to QueryBarDefineRule component

### Before

https://user-images.githubusercontent.com/92328789/193884969-3647e06b-085a-4923-82e8-546bedabeb3e.mp4

### After

https://user-images.githubusercontent.com/92328789/193884323-629fb879-3a51-4412-8b63-2f36afc618cb.mov

As side effect, it reduced number of requests for saved query:
#### Before
2 requests were sent
<img width="1995" alt="Screenshot 2022-10-05 at 09 39 09" src="https://user-images.githubusercontent.com/92328789/194018652-5612a032-e908-4e01-9858-2049c8e453e2.png">

#### After
Only one request sent

### Checklist
<img width="1996" alt="Screenshot 2022-10-05 at 09 37 12" src="https://user-images.githubusercontent.com/92328789/194018637-770a08df-832b-4838-a060-05058c436ed6.png">

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

(cherry picked from commit 4feb397)

Co-authored-by: Vitalii Dmyterko <[email protected]>
@vitaliidm
Copy link
Contributor

@deepikakeshav-qasource , the issue has been fixed in #142602

@vitaliidm vitaliidm added fixed QA:Ready for Testing Code is merged and ready for QA to validate labels Oct 11, 2022
@vitaliidm vitaliidm assigned ghost and unassigned vitaliidm Oct 11, 2022
@MadameSheema
Copy link
Member

@deepikakeshav-qasource please validate the fix on the last BC, thanks! :)

@ghost
Copy link
Author

ghost commented Oct 13, 2022

Hi @MadameSheema ,

We have validated this issue on 8.5.0 BC4 and observe that issue is Fixed. 🟢

Please find the below details:

Version: 8.5.0 BC4
BUILD: 57008
COMMIT: b2b4d5c5b4742fcfe5699dbcbffb9a98a5f06b5f

Screencast:

saved.query.mp4

Hence, we closing this issue and marking as QA Validated!!

Thanks!!

@ghost ghost added the QA:Validated Issue has been validated by QA label Oct 13, 2022
@ghost ghost closed this as completed Oct 13, 2022
@ghost ghost removed the QA:Ready for Testing Code is merged and ready for QA to validate label Jan 23, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Alerts Security Detection Alerts Area Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.5.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@banderror @elasticmachine @MadameSheema @marshallmain @vitaliidm