Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] [Event annotations] Addressing technical debt #141070

Open
Tracked by #169972
mbondyra opened this issue Sep 20, 2022 · 1 comment
Open
Tracked by #169972

[Lens] [Event annotations] Addressing technical debt #141070

mbondyra opened this issue Sep 20, 2022 · 1 comment
Labels
Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@mbondyra
Copy link
Contributor

  1. Review functional tests (maybe there's nothing to add, but when developing, we cut some corners here)
  2. An expression event_annotation_result runs some inner expressions twice -> one to get fetched annotation datatable, the other to return config layers. Maybe we could rethink it a bit?
  3. In the event_annotation_group we have a param annotations[] that takes either manual_point_event_annotation, manual_range_event_annotation or query_point_event_annotation. In the future we're planning on adding new types (for example ML annotation) so maybe it would be better to abstract all the different annotations expression types away the same way as essaggs takes agg_type that can take different forms (date_histogram, count and many more)
@mbondyra mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Sep 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@mbondyra mbondyra added the technical debt Improvement of the software architecture and operational architecture label Sep 20, 2022
@stratoula stratoula added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

3 participants