Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens][Query annotations] Discuss annotation query input #141037

Open
Tracked by #169972
mbondyra opened this issue Sep 20, 2022 · 3 comments
Open
Tracked by #169972

[Lens][Query annotations] Discuss annotation query input #141037

mbondyra opened this issue Sep 20, 2022 · 3 comments
Labels
discuss Feature:Lens papercut Small "burr" in the product that we should fix. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@mbondyra
Copy link
Contributor

So far we had two versions of the annotation query input and both come with their set of good and bad sides cc @MichaelMarcialis

  1. Query popover

Screenshot 2022-09-20 at 10 44 53

  • the whole query is visible both when the popover is closed and open, it's easy to see what's going on
  • it's an extra 'popup' in a already open flyout and it may take a while for the user to see what's going on, especially because it opens when switching from manual annotation.
Sep-20-2022.10-47-48.mp4
  1. Query inline input

Screenshot 2022-09-20 at 10 50 29

  • query is not fully visible when long and when closed
  • is very narrow so difficult to read when typing a query
  • it's not an extra element (just like the popup from 1) so it's just nicer to figure out what it does.

Screenshot 2022-09-20 at 10 50 46

Maybe we could come up with a compromise here?

@mbondyra mbondyra added discuss Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Sep 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@flash1293
Copy link
Contributor

I think we can find a different solution than the additional popover, but it's very important to have more screen space for this input. It's manageable for small examples but in a lot of common use cases these field names get much longer and the filter expressions are more complex especially for something like annotations. 300 pixels of width doesn't seems sufficient IMHO.

@MichaelMarcialis
Copy link
Contributor

I think there's a number of possible directions we can take to improve over both of the previous versions that @mbondyra mentions above. Some exploration possibilities that immediately come to mind include:

  • Switching from a single-line text input to a multi-line textarea (even when unfocused).
  • Adding an "expanded" mode, similar to what we do with the formula editor.
  • Allowing the user to horizontally resize the right-hand layer/configuration section (this is something we've avoided with good reason in the past, but bringing it up again here in case folks think it's worth discussing again).

There are likely other possibilities that I'm not thinking of at the moment, but one or more of these may be good to explore from the design side to see which would provide the most benefit. If we can plan to prioritize it against our other design to-dos, that would help me schedule time for that exploration.

@stratoula stratoula added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. papercut Small "burr" in the product that we should fix. labels Jan 30, 2024
@markov00 markov00 removed the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:Lens papercut Small "burr" in the product that we should fix. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

6 participants