Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Migrate away from EuiPageTemplate/EuiPageContent #139905

Closed
flash1293 opened this issue Sep 1, 2022 · 1 comment · Fixed by #142367
Closed

[Lens] Migrate away from EuiPageTemplate/EuiPageContent #139905

flash1293 opened this issue Sep 1, 2022 · 1 comment · Fixed by #142367
Assignees
@alexwizp
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@flash1293
Copy link
Contributor

There are a few places where the deprecated EuiPage* components are used:

  • x-pack/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/geo_field_workspace_panel.tsx
  • x-pack/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/geo_field_workspace_panel.tsx
  • x-pack/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel_wrapper.tsx

See https://elastic.github.io/eui/#/templates/page-template/guidelines#converting-from-legacy-layouts
@flash1293 flash1293 added technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Sep 1, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@alexwizp alexwizp self-assigned this Sep 29, 2022
alexwizp added a commit to alexwizp/kibana that referenced this issue Sep 30, 2022
@alexwizp
[Lens] Migrate away from EuiPageTemplate/EuiPageContent
2b5a73a 
Closes: elastic#139905
@alexwizp alexwizp mentioned this issue Sep 30, 2022
Merged
3 tasks
alexwizp added a commit that referenced this issue Oct 3, 2022
@alexwizp @kibanamachine
[Lens] Migrate away from EuiPageTemplate/EuiPageContent (#142367)
4db7564 
* [Lens] Migrate away from EuiPageTemplate/EuiPageContent

Closes: #139905

* fix FF issue

Co-authored-by: Kibana Machine <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this issue Oct 11, 2022
@alexwizp @kibanamachine @WafaaNasr
[Lens] Migrate away from EuiPageTemplate/EuiPageContent (elastic#142367)
f656de8 
* [Lens] Migrate away from EuiPageTemplate/EuiPageContent

Closes: elastic#139905

* fix FF issue

Co-authored-by: Kibana Machine <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this issue Oct 14, 2022
@alexwizp @kibanamachine @WafaaNasr
[Lens] Migrate away from EuiPageTemplate/EuiPageContent (elastic#142367)
3308e5c 
* [Lens] Migrate away from EuiPageTemplate/EuiPageContent

Closes: elastic#139905

* fix FF issue

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] Migrate away from EuiPageTemplate/EuiPageContent alexwizp/kibana
3 participants
@flash1293 @elasticmachine @alexwizp