Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Get rid of "Advanced sorting" switch for the Rules table #138907

Closed
3 tasks done
banderror opened this issue Aug 16, 2022 · 2 comments · Fixed by #149840
Closed
3 tasks done

[Security Solution] Get rid of "Advanced sorting" switch for the Rules table #138907

banderror opened this issue Aug 16, 2022 · 2 comments · Fixed by #149840
Assignees
@xcrzx
Labels
8.7 candidate enhancement New value added to drive a business result Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@banderror
Copy link
Contributor

banderror commented Aug 16, 2022 •
edited
Loading

Parent: https://github.com/elastic/security-team/issues/1972
Depends on: #130966
Related to: #112193

Summary

Once rule execution data (rule statuses and metrics) is stored inside rule Saved Objects themselves, we will be able to support filtering, sorting, and aggregation by (almost) all rule fields server-side. Thus, we won't need the in-memory Rules table mode anymore in which we load all rules in the browser and filter and sort in memory client-side.

Todo
@banderror banderror added enhancement New value added to drive a business result Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team 8.5 candidate labels Aug 16, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@banderror banderror changed the title [Security Solution] Get rid of Technical Preview for the Rules table [Security Solution] Get rid of "Advanced sorting" switch for the Rules table Nov 24, 2022
This was referenced Jan 24, 2023
Closed
Merged
@banderror banderror mentioned this issue Jan 27, 2023
Closed
@banderror banderror assigned xcrzx and unassigned maximpn Jan 27, 2023
@xcrzx xcrzx mentioned this issue Jan 30, 2023
Merged
xcrzx added a commit that referenced this issue Feb 7, 2023
@xcrzx
[Security Solution] Remove the advanced sorting switch from the rules…
4513f7b 
… management page (#149840)

**Resolves: #138907
**Resolves: #148196

## Summary

- Added missing `outcomeOrder` field to the alerting framework
- Removed the advanced sorting switch from the rules management page
- Both rules management and rules monitoring tables now have all columns
sortable, including indexing time, query time, last gap, and last
response
- Sorting now happens entirely on the server side. No in-memory
structures are needed.
- Removed the version column as intended in
#148196

There's one caveat, though. The running status is represented as a
different rule field. So when sorting by the last status, if there are
any "running" rules, they could appear in any row on the table:

![Screenshot 2023-01-31 at 16 18
29](https://user-images.githubusercontent.com/1938181/216108688-6abe9cb9-3307-4b72-9b6e-27a485a130d5.png)
@xcrzx xcrzx mentioned this issue Feb 8, 2023
Merged
@banderror banderror mentioned this issue Feb 21, 2023
Closed
4 tasks
@joepeeples joepeeples mentioned this issue Feb 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcrzx xcrzx

Labels
8.7 candidate enhancement New value added to drive a business result Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security Solution] Remove the advanced sorting switch from the rules management page xcrzx/kibana
4 participants
@xcrzx @maximpn @banderror @elasticmachine