-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Add a filter by rule execution status to the Rules table #138903
Closed
4 tasks done
Labels
8.9 candidate
enhancement
New value added to drive a business result
Feature:Rule Management
Security Solution Detection Rule Management area
Team:Detection Rule Management
Security Detection Rule Management Team
Team:Detections and Resp
Security Detection Response Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
v8.9.0
Comments
banderror
added
enhancement
New value added to drive a business result
Team:Detections and Resp
Security Detection Response Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Feature:Rule Management
Security Solution Detection Rule Management area
Team:Detection Rule Management
Security Detection Rule Management Team
8.5 candidate
labels
Aug 16, 2022
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Merged
6 tasks
nikitaindik
added a commit
that referenced
this issue
Jun 20, 2023
…n Rule Management page (#159865) **Resolves**: #138903 ## Summary Adds a dropdown that allows you to filter rules by their rule execution status to the Rule Management page. <img width="1583" alt="Screenshot 2023-06-16 at 16 34 23" src="https://github.com/elastic/kibana/assets/15949146/abc8234a-4c05-4195-bc15-86b76a108663"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
banderror
pushed a commit
that referenced
this issue
Jul 11, 2023
**Resolves: #138903 ## Summary Adds an E2E Cypress test to check filtering by execution status in the rules table. <img width="953" alt="Screenshot 2023-06-26 at 14 10 10" src="https://github.com/elastic/kibana/assets/15949146/e1eb67ed-779c-42ad-8194-04a26598cfbc">
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Jul 11, 2023
…60502) **Resolves: elastic#138903 ## Summary Adds an E2E Cypress test to check filtering by execution status in the rules table. <img width="953" alt="Screenshot 2023-06-26 at 14 10 10" src="https://github.com/elastic/kibana/assets/15949146/e1eb67ed-779c-42ad-8194-04a26598cfbc"> (cherry picked from commit c30a7d4)
kibanamachine
referenced
this issue
Jul 11, 2023
…0502) (#161618) # Backport This will backport the following commits from `main` to `8.9`: - [[Security Solution] Tests: Filter by rule execution status (#160502)](#160502) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nikita Indik","email":"nikita.indik@elastic.co"},"sourceCommit":{"committedDate":"2023-07-11T08:12:37Z","message":"[Security Solution] Tests: Filter by rule execution status (#160502)\n\n**Resolves: https://github.com/elastic/kibana/issues/138903**\r\n\r\n## Summary\r\n\r\nAdds an E2E Cypress test to check filtering by execution status in the\r\nrules table.\r\n<img width=\"953\" alt=\"Screenshot 2023-06-26 at 14 10 10\"\r\nsrc=\"https://github.com/elastic/kibana/assets/15949146/e1eb67ed-779c-42ad-8194-04a26598cfbc\">","sha":"c30a7d47eb4a467734b08bfea1d8d3c3c301b5cb","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","test_ui_functional","release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Feature:Rule Management","Team:Detection Rule Management","v8.9.0","v8.10.0"],"number":160502,"url":"https://github.com/elastic/kibana/pull/160502","mergeCommit":{"message":"[Security Solution] Tests: Filter by rule execution status (#160502)\n\n**Resolves: https://github.com/elastic/kibana/issues/138903**\r\n\r\n## Summary\r\n\r\nAdds an E2E Cypress test to check filtering by execution status in the\r\nrules table.\r\n<img width=\"953\" alt=\"Screenshot 2023-06-26 at 14 10 10\"\r\nsrc=\"https://github.com/elastic/kibana/assets/15949146/e1eb67ed-779c-42ad-8194-04a26598cfbc\">","sha":"c30a7d47eb4a467734b08bfea1d8d3c3c301b5cb"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160502","number":160502,"mergeCommit":{"message":"[Security Solution] Tests: Filter by rule execution status (#160502)\n\n**Resolves: https://github.com/elastic/kibana/issues/138903**\r\n\r\n## Summary\r\n\r\nAdds an E2E Cypress test to check filtering by execution status in the\r\nrules table.\r\n<img width=\"953\" alt=\"Screenshot 2023-06-26 at 14 10 10\"\r\nsrc=\"https://github.com/elastic/kibana/assets/15949146/e1eb67ed-779c-42ad-8194-04a26598cfbc\">","sha":"c30a7d47eb4a467734b08bfea1d8d3c3c301b5cb"}}]}] BACKPORT--> Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.9 candidate
enhancement
New value added to drive a business result
Feature:Rule Management
Security Solution Detection Rule Management area
Team:Detection Rule Management
Security Detection Rule Management Team
Team:Detections and Resp
Security Detection Response Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
v8.9.0
Epic: https://github.com/elastic/security-team/issues/5624 (internal)
Design: Figma (internal)
Docs ticket: elastic/security-docs#3486
Summary
We'd like to implement a new filter by rule execution status and add it to the Rules and Rule Monitoring tables. Rule execution status corresponds to the "Last response" column. We have designs for it but we might want to revisit them because they were created a relatively long time ago.
Bonus: if needed, we can add support for sorting by this column as well.
Todo
The text was updated successfully, but these errors were encountered: