Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Synthetics Integration] Deprecate Legacy Elastic Synthetics Integration edit flow #137505

Closed
1 task done
Tracked by #137508
dominiqueclarke opened this issue Jul 28, 2022 · 5 comments · Fixed by #149506
Closed
1 task done
Tracked by #137508
Assignees
Labels
enhancement New value added to drive a business result Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability

Comments

@dominiqueclarke
Copy link
Contributor

dominiqueclarke commented Jul 28, 2022

Issue updated to reflect the latest discussions/decisions.

#150287 raised to add stronger messaging in 8.7 of the upcoming deprecation in 8.8.

This issue is to remove the Integration capabilities of Zip URL and Inline monitors from the Synthetics Integration (internally, the Integration is still needed as it’s used for delivering Private Locations).

ACs:

Original description

Prerequisites:

Disable the ability to edit Elastic Synthetics integrations outside Uptime/Synthetics monitor management, encouring users to migrate to UI Monitor Management.

This can be done either through a button directing users to Uptime or Synthetics for the migration or by immediately redirecting users to Uptime or Synthetics for the migration.

This assumes that a migration path is available for moving legacy Synthetics integration policies into UI Monitor Management via #137494

Edit monitor flow for legacy integrations

Disables the ability to edit the monitor, displaying a prompt to migrate the monitor to Uptime/Synthetics monitor management in order to edit

Edit monitor flow for migrated integrations

Once the monitor is fully migrated, the edit flow will follow the UX described in elastic/uptime#475

@dominiqueclarke dominiqueclarke added enhancement New value added to drive a business result Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jul 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@paulb-elastic
Copy link
Contributor

paulb-elastic commented Feb 1, 2023

Further to a team discussion the other day, here's a clarification of the current behaviour:

8.4 (Tested 8.4.3)

  • Can add Synthetics Integrations for all types of monitor
    • Lightweight
    • Browser
      • ZIP URL
      • Inline

8.5 (Tested 8.5.3)

  • UI allows Synthetics Integrations to be added as with 8.4
  • However does call out that ZIP URLs are being deprecated
    image
  • ⚠️ ZIP URLs seem to be broken, in that when they are created/saved, the URL doesn't actually save
    • This also affects upgrades - see below
  • Upgrading from 8.4.3 to 8.5.3
    • All Synthetics Integration policies are still there
      image
    • ⚠️ As with ZIP URLs created in 8.5.3, those created in 8.4.3 and migrated to 8.5.3 no longer have a URL defined
      image
    • All other types (Browser Inline and Lightweight) still have the Script/URL/host set

8.6 (Tested 8.6.1)

  • Synthetics Integration not shown unless you toggle “Display beta integrations” to on
  • Even if set, cannot add new Synthetics Integration (monitors) but get a banner to use Uptime Monitor Management instead
    image
  • Upgrading from 8.5.3 to 8.6.1
    • Existing Synthetics Integrations are still there (ZIP URLs still missing URL as in 8.5.3)

8.7.0-SNAPSHOT (Tested build as ok 01/Feb/2023)

  • Same as 8.6.1
    • Can't add new Synthetics Integrations
    • Existing Synthetics Integrations are still there (ZIP URLs still missing URL)

Summary

  • ZIP URLs are not likely to be valid/working from 8.5 onwards
  • Users haven't been able to add new Synthetics Integration monitors from 8.6
  • Suggestion:
    • In 8.7
      • If there are any Synthetics Integrations defined, add a notification banner in Uptime (see below)
      • In the edit flow of the existing Integration Policy, add a notification (see below)
    • In 8.8
      • Stop any Synthetics Integration monitors from running
      • Update the Synthetics Integration UI to clarify what it is (internal, not for use)
      • Remove the notification banner added in 8.7
    • The notification/banner should clarify:
      • Synthetics Integration monitors will stop running in 8.8 and their configuration will be inaccessible from 8.8 onwards
      • Migrate to monitors configured through the UI (ideally Synthetics UI rather than Uptime Monitor Management) or Project Monitors
      • Include details in the release notes

@paulb-elastic
Copy link
Contributor

Description updated based on recent discussions

@paulb-elastic
Copy link
Contributor

Updated the description that the stopping of the monitors will be done in Beats elastic/beats#34506 (legacy integration policies won't be deleted).

@dominiqueclarke dominiqueclarke self-assigned this Mar 25, 2023
dominiqueclarke added a commit that referenced this issue Mar 28, 2023
## Summary
Fixes #137505

Shows deprecation notice when attempting to edit legacy integrations

[Elastic-Synthetics---Integrations---Elastic
(1).webm](https://user-images.githubusercontent.com/11356435/228042467-9b9a593a-a713-4a38-aa6a-1c083e82f3c5.webm)

### Testing
1. Check out the 8.5 branch
2. Create a legacy Elastic Synthetics integration
3. Check out this branch
4. Navigate to the legacy Elastic Synthetics integration
5. Observe the deprecation notice

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Dominique Clarke <[email protected]>
@dominiqueclarke dominiqueclarke self-assigned this May 10, 2023
@dominiqueclarke
Copy link
Contributor Author

Post FF testing LGTM on a snapshot from May 10th

Screen Shot 2023-05-10 at 2 22 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants