-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Enable button not working on rule details page for custom users #137149
Comments
Pinging @elastic/security-solution (Team: SecuritySolution) |
@manishgupta-qasource please review! |
Reviewed & assigned to @MadameSheema |
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
During a pair-testing session with @patrykkopycinski we faced the same behavior for an enterprise license with the following custom role.{
"test": {
"cluster": [
"all"
],
"indices": [
{
"names": [
"*"
],
"privileges": [
"all"
],
"field_security": {
"grant": [
"*"
],
"except": []
},
"allow_restricted_indices": false
}
],
"applications": [
{
"application": "kibana-.kibana",
"privileges": [
"feature_siem.all",
"feature_securitySolutionCases.all",
"feature_osquery.minimal_all",
"feature_osquery.live_queries_read",
"feature_osquery.run_saved_queries",
"feature_osquery.saved_queries_all",
"feature_osquery.saved_queries_read",
"feature_osquery.packs_all",
"feature_osquery.packs_read",
"feature_actions.read"
],
"resources": [
"*"
]
}
],
"run_as": [],
"metadata": {},
"transient_metadata": {
"enabled": true
}
}
} |
Two reasons can cause this bug:
|
… state (#143252) **Resolves:** [#137149](#137149) ## Summary Disables rule details enable/disable toggle for ML rules only under basic license. Before: https://user-images.githubusercontent.com/3775283/195514871-f0ccb25e-177d-4b4e-83bc-9c26da1718f0.mov After: https://user-images.githubusercontent.com/3775283/195513340-95944c6d-da6d-4ab3-9917-4e03f5791d3a.mov ### Checklist - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
@muskangulati-qasource Fixed in #143252 (it has been merged in main which corresponds to 8.6.0, we're also targeting 8.5.1 and going to backport it to 8.5 branch when 8.5.0 will be released). |
@maximpn Please backport the fix to the |
… state (elastic#143252) **Resolves:** [elastic#137149](elastic#137149) ## Summary Disables rule details enable/disable toggle for ML rules only under basic license. Before: https://user-images.githubusercontent.com/3775283/195514871-f0ccb25e-177d-4b4e-83bc-9c26da1718f0.mov After: https://user-images.githubusercontent.com/3775283/195513340-95944c6d-da6d-4ab3-9917-4e03f5791d3a.mov ### Checklist - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit 931987d)
… state (#143252) (#144738) **Resolves:** [#137149](#137149) ## Summary Disables rule details enable/disable toggle for ML rules only under basic license. Before: https://user-images.githubusercontent.com/3775283/195514871-f0ccb25e-177d-4b4e-83bc-9c26da1718f0.mov After: https://user-images.githubusercontent.com/3775283/195513340-95944c6d-da6d-4ab3-9917-4e03f5791d3a.mov ### Checklist - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit 931987d) Co-authored-by: Kibana Machine <[email protected]>
@muskangulati-qasource @banderror The fix has been backported to |
Hi Team, We have validated this issue on 8.5.1 BC1 and found the issue is fixed now. ✔️ Build Details:
Screen Recording: Rule.mp4Please let us know if anything else is required from our end. Thanks !!! |
Hi Team, We have validated this issue on 8.6.0 BC1 and found the issue is fixed now. ✔️ Build Details:
Screen Recording: Rules.-.Kibana.Mozilla.Firefox.2022-11-17.15-37-45.mp4Hence we are marking this as QA validated. Thanks ! |
Describe the bug
Build info
Preconditions
superuser
superuser
should not be part of the roles the user hascustomized
kibana privilegesSteps to Reproduce
Actual Result
Expected Result
Screen Recording
https://user-images.githubusercontent.com/60252716/180953989-d8427a6b-eda0-4bbc-b49f-5214e585e010.mp4
Workaround:
Rules
pageExtra information:
The text was updated successfully, but these errors were encountered: