Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Change agent action APIs to PUT instead of POST #136805

Closed
Tracked by #123150
juliaElastic opened this issue Jul 21, 2022 · 2 comments · Fixed by #152236
Closed
Tracked by #123150

[Fleet] Change agent action APIs to PUT instead of POST #136805

juliaElastic opened this issue Jul 21, 2022 · 2 comments · Fixed by #152236
Assignees
@criamico
Labels
enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@juliaElastic
Copy link
Contributor

Fleet Agent action APIs are not consistent.
Reassign uses PUT, the others use POST: https://petstore.swagger.io/?url=https://raw.githubusercontent.com/elastic/kibana/main/x-pack/plugins/fleet/common/openapi/bundled.json#/default/reassign-agent

Change the following APIs to PUT, and make the POST versions deprecated.

https://petstore.swagger.io/?url=https://raw.githubusercontent.com/elastic/kibana/main/x-pack/plugins/fleet/common/openapi/bundled.json#/default/unenroll-agent

https://petstore.swagger.io/?url=https://raw.githubusercontent.com/elastic/kibana/main/x-pack/plugins/fleet/common/openapi/bundled.json#/default/upgrade-agent
@juliaElastic juliaElastic added enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@juliaElastic juliaElastic mentioned this issue Jul 21, 2022
Closed
21 tasks
@nchaulet
Copy link
Member

@juliaElastic should we change the reassign to POST instead? I do not think our agent action APIs are idempotent and POST seems more appropriate in this case

@criamico criamico mentioned this issue Feb 27, 2023
Merged
2 tasks
criamico added a commit that referenced this issue Feb 27, 2023
@criamico
[Fleet] Change agent reassign API from PUT to POST (#152236)
17e41eb 
Closes #136805

## Summary
Change `agents/{agentId}/reassign` API from `PUT` to `POST` to make it
consistent with other APIs on agent actions

As part of this task I'm marking as deprecated the PUT endpoint and
updating the openApi docs


### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this issue Mar 10, 2023
@criamico @bmorelli25
[Fleet] Change agent reassign API from PUT to POST (elastic#152236)
84c5603 
Closes elastic#136805

## Summary
Change `agents/{agentId}/reassign` API from `PUT` to `POST` to make it
consistent with other APIs on agent actions

As part of this task I'm marking as deprecated the PUT endpoint and
updating the openApi docs


### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@criamico criamico

Labels
enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Change agent reassign API from PUT to POST criamico/kibana
4 participants
@nchaulet @elasticmachine @criamico @juliaElastic