Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Warning Color & Tooltip for Unsaved Changes Badge #133857

Closed
Tracked by #144752
jughosta opened this issue Jun 8, 2022 · 6 comments · Fixed by #154253
Closed
Tracked by #144752

[Dashboard] Warning Color & Tooltip for Unsaved Changes Badge #133857

jughosta opened this issue Jun 8, 2022 · 6 comments · Fixed by #154253
Assignees
Labels
enhancement New value added to drive a business result Feature:Dashboard Dashboard related features good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas usability

Comments

@jughosta
Copy link
Contributor

jughosta commented Jun 8, 2022

Kibana version: 8.3

Description of the problem including expected versus actual behavior:

  • Can we change "Unsaved changes" badge color to a warning color instead?
  • It would be great to add a tooltip to the badge and suggest what to do to save those changes.

Steps to reproduce:

  1. Create a dashboard and add a visualization
  2. Edit visualization
  3. Notice that "Unsaved changes" badge appeared at the top

Screenshot 2022-06-08 at 11 13 56

@jughosta jughosta added Feature:Dashboard Dashboard related features enhancement New value added to drive a business result usability Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Jun 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor

I've been thinking about having a tooltip here for a while. The tooltip could elaborate on what exactly has changed on the dashboard, and could tell the user to click save to clear it.

@andreadelrio, what do you think about changing the unsaved changes badge to the warning color instead of secondary?

@andreadelrio
Copy link
Contributor

I've been thinking about having a tooltip here for a while. The tooltip could elaborate on what exactly has changed on the dashboard, and could tell the user to click save to clear it.

@andreadelrio, what do you think about changing the unsaved changes badge to the warning color instead of secondary?

I think switching to the warning color makes a lot of sense. That secondary color also represents "success" so it's a bit misleading here.

@ThomThomson ThomThomson added good first issue low hanging fruit loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed triage_needed labels Jun 15, 2022
@10xtechie
Copy link
Contributor

Hello @ThomThomson, @jughosta, @andreadelrio
I have locally made the suitable codes changes for this enhancement - please see the screenshot below.

kdb

Please let me know exact what message you want to see on tooltip and what we should do for i18n translation of the tooltip message. Also, please assign this issue to me :)

@ThomThomson
Copy link
Contributor

That looks great so far @10xtechie, would you mind opening a PR against the main branch for your change and we can discuss further there? So far, we don't have a system in place for showing the user exactly which pieces of the dashboard has changed, but I think it's still a good idea to have a tooltip that says something like:

"This dashboard has changed since the last time it was saved. To clear this message save the dashboard"

Tagging @KOTungseth for copywriting help with this!

10xtechie added a commit to 10xtechie/kibana that referenced this issue Jun 17, 2022
10xtechie added a commit to 10xtechie/kibana that referenced this issue Jun 18, 2022
@10xtechie
Copy link
Contributor

@ThomThomson ,
I have updated the PR based your comment. Could you please review ?

10xtechie added a commit to 10xtechie/kibana that referenced this issue Jun 21, 2022
@ThomThomson ThomThomson changed the title [Dashboard] Enhancement for "Unsaved changes" badge [Dashboard] Warning Color & Tooltip for Unsaved Changes Badge Dec 20, 2022
@nickpeihl nickpeihl self-assigned this Mar 8, 2023
nickpeihl pushed a commit to nickpeihl/kibana that referenced this issue Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Dashboard Dashboard related features good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas usability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants