Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Exceptions] - Add exception flyout #131668

Closed
9 tasks
Tracked by #131674
yctercero opened this issue May 5, 2022 · 3 comments
Closed
9 tasks
Tracked by #131674

[Security Solution][Exceptions] - Add exception flyout #131668

yctercero opened this issue May 5, 2022 · 3 comments
Assignees
Labels
8.4 candidate Feature:Rule Exceptions Security Solution Detection Rule Exceptions area Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@yctercero
Copy link
Contributor

yctercero commented May 5, 2022

Use cases

  • As a detection engineer or analyst I want to be able to add one or more rule exceptions to a single rule.
  • As a detection engineer or analyst I want to be able to add one or more rule exceptions to a shared lsit.

To Do

  • User can name their exception
  • User can add entries (like our existing UI)
  • User can assign exception item to default rule list
  • User can assign exception to shared exception lists
    • If rule does not have any shared exception lists assigned, option to add to shared list is disabled
  • User can add comment
  • User can select to bulk close alerts (if conditions met)

Design

Check figma for latest design.

Screen Shot 2022-10-10 at 11 57 24 AM

Initial strategy

  • Existing flyout can be used and will just need to modify in order to add functionality of assigning to multiple rules and allowing user to add a name
  • All necessary APIs exist
@botelastic botelastic bot added the needs-team Issues missing a team label label May 5, 2022
@yctercero
Copy link
Contributor Author

yctercero commented May 5, 2022

@jethr0null @yiyangliu9286

For my own curiosity - when would a user want to have the ability to assign an exception item to multiple lists, vs assign to multiple rules? Let's say there's a false positive I want applied to all my rules, wouldn't I have some sort of global exceptions list I use to then assign to all my rules vs thinking of it as a single exception item that needs applied to all rules? I was working off of old designs!

Also, items can already have tags, do we want to expose that option to users. I could see us leveraging tags to then do the kind of bulk editing that you were talking about @jethr0null

@yctercero yctercero self-assigned this May 5, 2022
@yctercero yctercero added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Exceptions Security Solution Detection Rule Exceptions area Team:Security Solution Platform Security Solution Platform Team 8.4 candidate and removed needs-team Issues missing a team label labels May 5, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@yctercero
Copy link
Contributor Author

Hey! I've started on this ticket and hitting some edge cases I'd love some input on:

  • If user is creating an exception item for a list that has yet to be assigned to a rule - do we allow them to continue adding exceptions, just there's no autocomplete and a warning letting them know?
    • This wasn't a use case prior because you could only access this flow from a rule as opposed to here which a user can access this from all exceptions view
  • If user accesses this flow from the all exceptions view, and say the list is assigned to 10 rules - do we then populate the exception options using all fields from all 10 rule indices?

cc: @peluja1012 @jethr0null @yiyangliu9286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.4 candidate Feature:Rule Exceptions Security Solution Detection Rule Exceptions area Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

No branches or pull requests

3 participants