-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Exceptions] - New add/edit exception item flyouts #140643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the flyouts themselves
9 tasks
1e60825
to
a249725
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #131668, #131671, #143014, #143015.
Updates the exception item add/edit flyout to match new designs and flows. While this can only be tested in our current UI from the rule details page, alerts, alert details flyout, it's been built out for the other cases where it will be used - rule bulk actions and exception list management.
To Do
rule_exceptions/components
Breaking down the changes
packages/kbn-securitysolution-autocomplete/
false
, so this custom option functionality is optionalx-pack/plugins/lists/public/exceptions/components/builder/
x-pack/plugins/security_solution/cypress/e2e/exceptions/
x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/add_exception_flyout/
x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/edit_exception_flyout/
x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/all_exception_items_table/
listTypes
since now the table isn't justendpoint
exceptions ordetection
exceptions, it can includerule_default
list typex-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/exception_item_card
x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/logic/
x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/logic/use_exception_flyout_data.tsx
data_view_id
if one is defined or theindex
to fetch the fieldsx-pack/plugins/security_solution/public/detections/components/alerts_table/timeline_actions/
Existing questions
list
?Addresses
#127696, #99597, #117289, #99022, #135254, #102460, #116586
Screenshots
Shows exception item that is part of a shared list

Add endpoint exception
Edit endpoint exception
Add rule exception
Edit rule exception
Checklist
For maintainers