Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Session View] UI fixies (QA design #3) #130155

Closed
12 tasks done
codearos opened this issue Apr 13, 2022 · 2 comments
Closed
12 tasks done

[Session View] UI fixies (QA design #3) #130155

codearos opened this issue Apr 13, 2022 · 2 comments
Assignees
@animehart @opauloh @Max-Iskra
Labels
bug Fixes for quality problems that affect the customer experience Team: AWP: Platform Adaptive Workload Protection Platform team from Security Solution Team: AWP: Visualization AWP team that does most fullstack work in kibana v8.2.1 v8.3.0

Comments

@codearos
Copy link

codearos commented Apr 13, 2022 •
edited by opauloh
Loading

Toobar

  • Big spacing between FInd Verbose mode and Details panel btn. Correct padding: 8px
  • Toolbar has a background-color: white. Correct value:$euiFormBackgroundDisabledColor.

Details Panel

  • Alert name overlaps with controls. Long alert name should be truncated. ➡️ Figma file

Frame

Command line

Alerts block

Fullscreen state
@codearos codearos added bug Fixes for quality problems that affect the customer experience Team: AWP: Platform Adaptive Workload Protection Platform team from Security Solution labels Apr 13, 2022
@Max-Iskra Max-Iskra self-assigned this Apr 14, 2022
@opauloh
Copy link
Contributor

opauloh commented Apr 19, 2022 •
edited
Loading

There is an open discussion if we will want to update the tokens that are different in Dark mode vs Light mode to use the same tokens for better maintainability, I'm waiting for a decision if we will change the tokens to be the same, or stick with the difference.

cc @codearos @Max-Iskra

@opauloh opauloh self-assigned this Apr 19, 2022
@mitodrummer mitodrummer added v8.3.0 Team: AWP: Visualization AWP team that does most fullstack work in kibana labels Apr 21, 2022
@animehart animehart self-assigned this Apr 21, 2022
@opauloh opauloh mentioned this issue May 10, 2022
Merged
1 task
@opauloh opauloh added the v8.2.1 label May 16, 2022
@opauloh opauloh closed this as completed May 16, 2022
@opauloh
Copy link
Contributor

opauloh commented Jun 7, 2022

removed #131101 from this list since it won't make for v8.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@animehart animehart

@opauloh opauloh

@Max-Iskra Max-Iskra

Labels
bug Fixes for quality problems that affect the customer experience Team: AWP: Platform Adaptive Workload Protection Platform team from Security Solution Team: AWP: Visualization AWP team that does most fullstack work in kibana v8.2.1 v8.3.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@animehart @mitodrummer @opauloh @codearos @Max-Iskra