[Accessibility] Management Popularity Field "plus" and "minus" should be read as "increment popularity" and "decrement popularity" #12865
Labels
Comments
9 tasks
tbragin
added
the
bug
|
Where are you seeing |
|
I think the screen reader reads the string "+" as plus and likewise with "-" and minus. Adding a new aria attribute should override that. |
|
Okay thanks! |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this issue
Aug 8, 2017
chrisronline
added a commit
that referenced
this issue
Aug 10, 2017
* Use header/h tag for tab header, #12861 * Add tabindexes for tables, #12862 * Add for/id pairings, #12863 * Search role, #12868 * Use better descriptions for aria labels, #12865 * Add aria label, #12870 * Button and a tags are already in tab order, removing unnecessary change * The input field cannot contain the role="search" * The tabindex needs to be on the element which the click handler * Remove tabindex and remove the class applying the hover styles - honestly, we can probably make due without any class (using default h2 styles) * Revert "Remove tabindex and remove the class applying the hover styles - honestly, we can probably make due without any class (using default h2 styles)" This reverts commit c54ea227889898baef85ee71b3350bbf69ef5d7c. * Remove the extra code my cat added * Addressing hidden inputs from #12863 * Remove unnecessary header tag * Add clarifying comment * Prevent multiple ids
chrisronline
added a commit
that referenced
this issue
Aug 10, 2017
* Use header/h tag for tab header, #12861 * Add tabindexes for tables, #12862 * Add for/id pairings, #12863 * Search role, #12868 * Use better descriptions for aria labels, #12865 * Add aria label, #12870 * Button and a tags are already in tab order, removing unnecessary change * The input field cannot contain the role="search" * The tabindex needs to be on the element which the click handler * Remove tabindex and remove the class applying the hover styles - honestly, we can probably make due without any class (using default h2 styles) * Revert "Remove tabindex and remove the class applying the hover styles - honestly, we can probably make due without any class (using default h2 styles)" This reverts commit c54ea227889898baef85ee71b3350bbf69ef5d7c. * Remove the extra code my cat added * Addressing hidden inputs from #12863 * Remove unnecessary header tag * Add clarifying comment * Prevent multiple ids
chrisronline
added a commit
that referenced
this issue
Aug 10, 2017
* Use header/h tag for tab header, #12861 * Add tabindexes for tables, #12862 * Add for/id pairings, #12863 * Search role, #12868 * Use better descriptions for aria labels, #12865 * Add aria label, #12870 * Button and a tags are already in tab order, removing unnecessary change * The input field cannot contain the role="search" * The tabindex needs to be on the element which the click handler * Remove tabindex and remove the class applying the hover styles - honestly, we can probably make due without any class (using default h2 styles) * Revert "Remove tabindex and remove the class applying the hover styles - honestly, we can probably make due without any class (using default h2 styles)" This reverts commit c54ea227889898baef85ee71b3350bbf69ef5d7c. * Remove the extra code my cat added * Addressing hidden inputs from #12863 * Remove unnecessary header tag * Add clarifying comment * Prevent multiple ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The buttons function fine but "plus" and "minus" are not descriptive enough. They should read "increment popularity" and "decrement popularity" respectively.
The text was updated successfully, but these errors were encountered: