Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EQLSearchStrategy] Clean up and align with other async strategies #128635

Open
9 tasks
Dosant opened this issue Mar 28, 2022 · 2 comments
Open
9 tasks

[EQLSearchStrategy] Clean up and align with other async strategies #128635

Dosant opened this issue Mar 28, 2022 · 2 comments
Labels
Feature:Search Querying infrastructure in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture

Comments

@Dosant
Copy link
Contributor

Dosant commented Mar 28, 2022

Similar like we did to low level SQL strategy, we should clean up EQL search strategy and align it with other async strategies:

Ideally we should do it before wider adoption in Kibana (unified search).

Here is the list of possible alignment things:

  • Is it Required to return both headers + body in the response?
    export type EqlSearchStrategyResponse<T = unknown> = IKibanaSearchResponse<TransportResult<T>>;
    . Can we do body + warning as in other strategies?
  • Can we better type it using EqlSearchResponse ?
  • Don't use deprecatated typesWithBodyKey format
  • Type search request with EqlSearchRequest and EqlGetRequest
  • Don't provide unsupported by strategies params / options to avoid ts-ignore:
    : // @ts-expect-error optional key cannot be used since search doesn't expect undefined
    . Make params explicit
  • Properly use submit / get async utils
  • Add example plugin
  • Add function test for example plugin
  • Add API test for search strategy
@Dosant Dosant added Feature:Search Querying infrastructure in Kibana technical debt Improvement of the software architecture and operational architecture Team:AppServicesSv labels Mar 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Apr 5, 2022
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Oct 20, 2022
@petrklapka petrklapka added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:AppServicesSv labels Nov 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@lukasolson lukasolson added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

4 participants