Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[search] align sql search strategy with ese #119280

Closed
ppisljar opened this issue Nov 22, 2021 · 3 comments · Fixed by #127859
Closed

[search] align sql search strategy with ese #119280

ppisljar opened this issue Nov 22, 2021 · 3 comments · Fixed by #127859
Labels
Feature:Search Querying infrastructure in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@ppisljar
Copy link
Member

currently SQL search stragegy behaves a bit differently from the other search stragegies and should be aligned.

@ppisljar ppisljar added Feature:Search Querying infrastructure in Kibana Team:AppServicesSv labels Nov 22, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Nov 22, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:medium Medium Level of Effort labels Dec 14, 2021
@Dosant
Copy link
Contributor

Dosant commented Jan 28, 2022

Gap analysis:

  • I think this strategy is generic enough and can be moved from canvas x-pack/plugins/canvas/server/lib/essql_strategy.ts to data plugin
  • We need to decide if we want this to be sync or async or both (2 strategies).
  • Similar to default stratgies we should:
    • Align Request payload:
      • move query specific staff into params. Keep id and params on root
      • introduce options support for abortSignal, searchSession params, executionContext, etc ...
    • Align Response payload:
      • searchSession params, warning, total etc...
    • Add search usage tracking
    • For async implement cancel and extend methods

@Dosant
Copy link
Contributor

Dosant commented Mar 24, 2022

Next steps for SQL strategy in data plugin:

  • Work with [unified search] team on higher-level building blocks for their needs (replacement of SearchSource, expression, etc...)
  • Work with [canvas] team to see if we can migrate to using this sql strategy as a low-level primitive for their strategy: is async SQL stable enough to switch canvas to use it? Also figure out how to avoid having second sql expression function for this strategy
  • See what's next for search session before finishing this strategy to support sessions

@petrklapka petrklapka added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:AppServicesSv labels Nov 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants