Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Download icon looks like a share icon #121759

Closed
Tracked by #120277
gavinwye opened this issue Dec 21, 2021 · 6 comments
Closed
Tracked by #120277

[Security Solution] Download icon looks like a share icon #121759

gavinwye opened this issue Dec 21, 2021 · 6 comments
Assignees
@gavinwye @yctercero
Labels
bug Fixes for quality problems that affect the customer experience fixed QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. UX: UI/UX Consultation Requires UX lead input/consult before development and UX lead approval on PR before merge. v8.0.0 v8.1.0

Comments

@gavinwye
Copy link

gavinwye commented Dec 21, 2021 •
edited
Loading

Describe the bug:
On the exceptions page the download icon looks similar to a share icon

Kibana/Elasticsearch Stack version:

v 7.16.1

Original install method (e.g. download page, yum, from source, etc.):
Eden

Current behavior:

Clicked the share icon expecting to be able to share the list, but was asked to download the list.

Expected behavior:

Change the icon to a download icon. We should think about if we're adding this so that users can actually share the list, if that's the case we should make it easy for them to share and not force them to download the list. If there are technical limitations around sharing, (maybe because lists don't have unique URL's in the app?) we should make it clear to users that they need to download the list then share it.

The aria-label="Export exception list" suggests that this is about downloading the list rather than sharing.

Screenshots (if relevant):
image
@gavinwye gavinwye added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Dec 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@gavinwye gavinwye added the UX: UI/UX Consultation Requires UX lead input/consult before development and UX lead approval on PR before merge. label Dec 21, 2021
@gavinwye gavinwye self-assigned this Dec 22, 2021
@gavinwye gavinwye mentioned this issue Dec 27, 2021
Open
25 tasks
@yctercero yctercero mentioned this issue Jan 12, 2022
Merged
2 tasks
yctercero added a commit that referenced this issue Jan 17, 2022
@yctercero
update exceptions table header and export icon (#122870)
8c0fbdf 
Addresses #121758 and #121759.

Updates exceptions table export icon to be "download" icon and updates exceptions table header to use native EUI page headers.
@yctercero
Copy link
Contributor

Fixed in #122870

@MadameSheema ready for QA check!

@MadameSheema
Copy link
Member

Thanks @yctercero!! :)

Is there any reason why this fix is targeting 8.1 and not 8.0? Thanks 😊

yctercero added a commit to yctercero/kibana that referenced this issue Jan 26, 2022
@yctercero
update exceptions table header and export icon (elastic#122870)
47e1d61 
Addresses elastic#121758 and elastic#121759.

Updates exceptions table export icon to be "download" icon and updates exceptions table header to use native EUI page headers.

(cherry picked from commit 8c0fbdf)
@yctercero
Copy link
Contributor

Backport to 8.0 started - #123787

@MadameSheema

yctercero added a commit that referenced this issue Jan 26, 2022
@yctercero @kibanamachine
update exceptions table header and export icon (#122870) (#123787)
8c9e96e 
Addresses #121758 and #121759.

Updates exceptions table export icon to be "download" icon and updates exceptions table header to use native EUI page headers.

(cherry picked from commit 8c0fbdf)

Co-authored-by: Kibana Machine <[email protected]>
@MadameSheema
Copy link
Member

@deepikakeshav-qasource please validate the following fix on latest 8.0-rc2, thanks! :)

@ghost
Copy link

ghost commented Feb 1, 2022

Hi @MadameSheema ,

We have validated this issue on 8.0.0 RC2 BC4 and observed that issue is Fixed. Download icon is displaying under exceptions tab.

Please find below testing details:

Build Details:

Version: 8.0.0 RC2 BC4
Build: 49192
Commit: 57ca5e139a33dd2eed927ce98d8231a1f217cd15

Screenshot:
image

Hence, We are closing this issue and marking as QA Validated.

@ghost ghost added the QA:Validated Issue has been validated by QA label Feb 1, 2022
@ghost ghost closed this as completed Feb 1, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gavinwye gavinwye

@yctercero yctercero

Labels
bug Fixes for quality problems that affect the customer experience fixed QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. UX: UI/UX Consultation Requires UX lead input/consult before development and UX lead approval on PR before merge. v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gavinwye @yctercero @elasticmachine @MadameSheema