Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Don't autofocus Visualize query bar #11856

Closed
cjcenizal opened this issue May 17, 2017 · 6 comments · Fixed by #13726
Closed

Accessibility: Don't autofocus Visualize query bar #11856

cjcenizal opened this issue May 17, 2017 · 6 comments · Fixed by #13726
Assignees
@timroes
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@cjcenizal
Copy link
Contributor

When the visualization page loads, focus is automatically set on the query bar in the Local Nav. Remove autofocus.

Relates to #11515.
@cjcenizal cjcenizal added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility labels May 17, 2017
@cjcenizal cjcenizal mentioned this issue May 17, 2017
Closed
38 tasks
@cjcenizal cjcenizal mentioned this issue Jun 6, 2017
Closed
20 tasks
@tbragin tbragin added the bug Fixes for quality problems that affect the customer experience label Jul 28, 2017
@timroes timroes self-assigned this Aug 23, 2017
@timroes
Copy link
Contributor

timroes commented Aug 25, 2017

With the discussion in #11515 in mind: should we really remove this? @cjcenizal and @aphelionz your up-to-date-thoughts about that?

@cjcenizal
Copy link
Contributor Author

Do we know if users benefit from autofocusing the query bar in a visualization? What's the expected user flow here?

@alexfrancoeur Any thoughts?

@cjcenizal
Copy link
Contributor Author

Also, @thomasneirynck and @ppisljar, your insights would be appreciated here.

@ppisljar
Copy link
Member

When creating a new visualization, the query bar is almost certainly not the first element you want to interact with. Probably you start by defining aggregations, setting the time range or setting visualization options.

When opening existing visualization I think its pretty much the same.

@timroes
Copy link
Contributor

timroes commented Aug 28, 2017

In that case I would just remove the autofocus from the query bar for visualizations. Thanks for your feedback.

timroes pushed a commit to timroes/kibana that referenced this issue Aug 28, 2017
Disable auto focus in visualizations, fix elastic#11856
d77cf46
@timroes timroes mentioned this issue Aug 28, 2017
Merged
@alexfrancoeur
Copy link

++ I agree with @ppisljar here

timroes added a commit that referenced this issue Aug 29, 2017
@timroes
Improve accessibility of visualization view (#13726)
4ddad1a 
* Use correct aria-label react attribute

* Label TSVB auto apply button, fix #12900

* Create possibility to conditionally disable input-focus directive

* Disable auto focus when creating a new viz, fix #12888

* Fix styling of label in TSVB

* Disable auto focus in visualizations, fix #11856

* Fix disable of auto focus

* Disable auto focus of index selection in vis wizard
timroes added a commit that referenced this issue Aug 29, 2017
@timroes
Improve accessibility of visualization view (#13726)
9d72dd0 
* Use correct aria-label react attribute

* Label TSVB auto apply button, fix #12900

* Create possibility to conditionally disable input-focus directive

* Disable auto focus when creating a new viz, fix #12888

* Fix styling of label in TSVB

* Disable auto focus in visualizations, fix #11856

* Fix disable of auto focus

* Disable auto focus of index selection in vis wizard
timroes added a commit that referenced this issue Aug 29, 2017
@timroes
Improve accessibility of visualization view (#13726)
c4c3ab1 
* Use correct aria-label react attribute

* Label TSVB auto apply button, fix #12900

* Create possibility to conditionally disable input-focus directive

* Disable auto focus when creating a new viz, fix #12888

* Fix styling of label in TSVB

* Disable auto focus in visualizations, fix #11856

* Fix disable of auto focus

* Disable auto focus of index selection in vis wizard
@timroes timroes mentioned this issue Jun 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timroes timroes

Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve accessibility of visualization view timroes/kibana
5 participants
@timroes @tbragin @cjcenizal @ppisljar @alexfrancoeur