Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Throughput charts broken when a filter is set #117226

Closed
MartinKolarik opened this issue Nov 2, 2021 · 2 comments · Fixed by #117370
Closed

[APM] Throughput charts broken when a filter is set #117226

MartinKolarik opened this issue Nov 2, 2021 · 2 comments · Fixed by #117370
Assignees
Labels
Team:APM All issues that need APM UI Team support

Comments

@MartinKolarik
Copy link

Kibana version

7.15.1

APM Server version (if applicable)

7.15.1

Elasticsearch version (if applicable)

7.15.1

Steps to Reproduce

  1. Set any kind of filter on the transactions tab.
  2. Check that the throughput chart matches the expectations.

Expected Behavior

The chart shows the throughput of the transactions that match the filter.

Actual Behavior

I'm not entirely sure what the charts show but it seems both the big throughput chart and the small one are wrong. In the first screenshot, the big one shows about 10 TPM, the small one shows 1762 TPM for the exact same thing, while the correct value is likely about 180 TPM (based on our regular requests, and based on what I see when the filter is removed, see the second screenshot).

image

Same time period, no filter. This one shows the correct value:

image

@MartinKolarik MartinKolarik added the Team:APM All issues that need APM UI Team support label Nov 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv
Copy link
Member

Thanks for opening this. I've been able to reproduce, and there is indeed a bug. It looks like transaction metrics are used instead of transactions when the search bar is used. The bug is located here:

export async function getSearchAggregatedTransactions({
config,
start,
end,
apmEventClient,
kuery,
}: {
config: APMConfig;
start?: number;
end?: number;
apmEventClient: APMEventClient;
kuery: string;
}): Promise<boolean> {
const searchAggregatedTransactions = config.searchAggregatedTransactions;
if (
kuery ||
searchAggregatedTransactions === SearchAggregatedTransactionSetting.auto
) {
return getHasAggregatedTransactions({ start, end, apmEventClient, kuery });
}
return (
searchAggregatedTransactions === SearchAggregatedTransactionSetting.always
);
}

dgieselaar added a commit to dgieselaar/kibana that referenced this issue Nov 3, 2021
@zube zube bot assigned smith Nov 3, 2021
@zube zube bot added [zube]: Done and removed [zube]: 7.16 labels Nov 3, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 3, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 3, 2021
smith pushed a commit to smith/kibana that referenced this issue Nov 3, 2021
Closes elastic#117226.
# Conflicts:
#	x-pack/plugins/apm/server/lib/helpers/transactions/index.ts
kibanamachine added a commit that referenced this issue Nov 3, 2021
smith added a commit that referenced this issue Nov 3, 2021
Closes #117226.
# Conflicts:
#	x-pack/plugins/apm/server/lib/helpers/transactions/index.ts

Co-authored-by: Dario Gieselaar <[email protected]>
kibanamachine added a commit that referenced this issue Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants