-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Log about individual status changes that occur after startup #116718
Comments
Pinging @elastic/kibana-core (Team:Core) |
I agree that having status changes of individual services/plugins logged could make sense, and would probably help for support too. I'm still a little concerned about the potential verbosity of the thing. As most plugins don't register custom status handlers, their status is computed depending on the statuses of their dependencies. In practice, that can lead to a lot of consecutive status changes. For example, if the We could potentially try to group these status changes by trying to identify the 'root' plugin/service that caused the change in the tree (something like So, are we fine just outputting a line in the log for each individual status change, even if in most scenario, we'll have dozen of such lines in every status change batch, or do we want more than that? |
I think individual log lines for any delayed status update (one that doesn't happening "immediately" after creation or something) sounds reasonable. They're all useful information that we should be making people aware of I think. |
## Summary New attempt at fixing #116718 Inspired on #126320 Here's what the newly logged `[status]` information looks like on a fresh startup: <img width="1834" alt="image" src="https://github.com/elastic/kibana/assets/25349407/d78d7f88-139f-4daf-9dc0-c4e6724ea412"> The first 2 entries are logs from Core services 🆕 . The next 5 entries are emitted due to `taskManager` plugin emitting a degraded status right at startup. I have created an issue to tackle that one: #168237 --------- Co-authored-by: kibanamachine <[email protected]>
We just spent a ton of time tracking down a plugin which was updating it's status from degraded to available very slowly. The vast majority of the time was spent just trying to understand how statuses were changing and would have been pretty trivial if we had seen a log line like:
I think it would be very useful to log these types of messages at an info level when they occur after some initial delay (to avoid a massive flood of messages about status changes as things startup).
The text was updated successfully, but these errors were encountered: