Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Add /internal to internal APIs #116334

Closed
paulb-elastic opened this issue Oct 26, 2021 · 3 comments · Fixed by #117852
Closed

[Uptime] Add /internal to internal APIs #116334

paulb-elastic opened this issue Oct 26, 2021 · 3 comments · Fixed by #117852
Assignees
@justinkambic
Labels
good first issue low hanging fruit Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.0.0

Comments

@paulb-elastic
Copy link
Contributor

paulb-elastic commented Oct 26, 2021 •
edited
Loading

Add /internal to internal APIs for:

  • Uptime
  • User Experience
@paulb-elastic paulb-elastic added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.0.0 good first issue low hanging fruit labels Oct 26, 2021
@deepak-sreekumar
Copy link
Contributor

deepak-sreekumar commented Oct 29, 2021 •
edited
Loading

Hi, I'd like to work on this. Could you please provide a bit more context also where/how I can find the list of APIs to work on?

@lucasfcosta lucasfcosta mentioned this issue Nov 8, 2021
Merged
9 tasks
@lucasfcosta
Copy link
Contributor

Hi @deepak-sreekumar, thanks a lot for your willingness to help 🙌

I've tackled this issue as it required a little bit of internal coordination to make sure that we'd rename things consistently across the parts of the application managed by different teams.

However, the PR is open for review (#117852) if you'd like to take a look at that and perhaps see how we usually change these types of things. Maybe that would make further contributions more straightforward.

Thanks a lot 😊

lucasfcosta added a commit to lucasfcosta/kibana that referenced this issue Nov 11, 2021
@lucasfcosta
[Uptime] prefix internal APIs with /internal [relates to elastic#116334]
41bb32c
lucasfcosta added a commit to lucasfcosta/kibana that referenced this issue Nov 11, 2021
@lucasfcosta
[Uptime] move hard-coded URL paths to rest_api constants [relates to e…
cbc6aa7 
…lastic#116334]
lucasfcosta added a commit to lucasfcosta/kibana that referenced this issue Nov 11, 2021
@lucasfcosta
[Uptime] use API_URLS from constants in API integration tests [relate…
e360c74 
…s to elastic#116334]
lucasfcosta added a commit to lucasfcosta/kibana that referenced this issue Nov 11, 2021
@lucasfcosta
[Uptime] prefix internal RUM routes with /internal and /ux [relates to …
0e614bc 
…elastic#116334]
lucasfcosta added a commit that referenced this issue Nov 11, 2021
@lucasfcosta
[Uptime] [User Experience] Prefix internal apis with /internal (#117852)
def6d85 
* [Uptime] prefix internal APIs with /internal [relates to #116334]

* [Uptime] move hard-coded URL paths to rest_api constants [relates to #116334]

* [Uptime] use API_URLS from constants in API integration tests [relates to #116334]

* [Uptime] Remove unnecessary filters route test

* [Uptime] prefix internal RUM routes with /internal and /ux [relates to #116334]

* [User Experience] update API docs for prefixed internal UX APIs
lucasfcosta added a commit to lucasfcosta/kibana that referenced this issue Nov 11, 2021
@lucasfcosta
[Uptime] [User Experience] Prefix internal apis with /internal (elast…
94084ce 
…ic#117852)

* [Uptime] prefix internal APIs with /internal [relates to elastic#116334]

* [Uptime] move hard-coded URL paths to rest_api constants [relates to elastic#116334]

* [Uptime] use API_URLS from constants in API integration tests [relates to elastic#116334]

* [Uptime] Remove unnecessary filters route test

* [Uptime] prefix internal RUM routes with /internal and /ux [relates to elastic#116334]

* [User Experience] update API docs for prefixed internal UX APIs
lucasfcosta added a commit that referenced this issue Nov 11, 2021
@lucasfcosta
[Uptime] [User Experience] Prefix internal apis with /internal (#117852…
1b1e803 
…) (#118380)

* [Uptime] prefix internal APIs with /internal [relates to #116334]

* [Uptime] move hard-coded URL paths to rest_api constants [relates to #116334]

* [Uptime] use API_URLS from constants in API integration tests [relates to #116334]

* [Uptime] Remove unnecessary filters route test

* [Uptime] prefix internal RUM routes with /internal and /ux [relates to #116334]

* [User Experience] update API docs for prefixed internal UX APIs
dmlemeshko pushed a commit that referenced this issue Nov 29, 2021
@lucasfcosta @dmlemeshko
[Uptime] [User Experience] Prefix internal apis with /internal (#117852)
c29c6e0 
* [Uptime] prefix internal APIs with /internal [relates to #116334]

* [Uptime] move hard-coded URL paths to rest_api constants [relates to #116334]

* [Uptime] use API_URLS from constants in API integration tests [relates to #116334]

* [Uptime] Remove unnecessary filters route test

* [Uptime] prefix internal RUM routes with /internal and /ux [relates to #116334]

* [User Experience] update API docs for prefixed internal UX APIs
@lucasfcosta lucasfcosta removed their assignment Dec 8, 2021
@justinkambic justinkambic self-assigned this Dec 17, 2021
@justinkambic
Copy link
Contributor

POST-FF testing LGTM

Where practicable I manually pinged the endpoints, I also walked through the UX dashboard and most features of the Uptime UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinkambic justinkambic

Labels
good first issue low hanging fruit Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Uptime] [User Experience] Prefix internal apis with /internal lucasfcosta/kibana
4 participants
@lucasfcosta @justinkambic @deepak-sreekumar @paulb-elastic