-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain the little up arrow at the bottom of visualisations #11381
Labels
Comments
e40pud
added a commit
to e40pud/kibana
that referenced
this issue
Dec 10, 2024
e40pud
added a commit
that referenced
this issue
Dec 12, 2024
…ab in the flyout (#11381) (#203601) ## Summary [Internal link](elastic/security-team#10820) to the feature details These changes add a possibility to edit, validate and save custom migration rules: * There are new `edit`, `save` and `cancel` buttons in the translation tab of the details flyout for the non-installed custom rules * There is a new ES|QL query editing component in the translation tab which allows edit and validate the ES|QL query * On saving the ES|QL query the custom migration rule will be updated and based on the ES|QL validation a new `translation_result` might be set: `full` if query is valid, `partial` if query has syntax errors, `untraslated` if query is an empty string. ## Screen recording https://github.com/user-attachments/assets/59cfc56f-3de8-4f7a-a2f9-79cb3fdee1c7 ### Other changes Next fixes and adjustments were also implemented as part of this PR: * `Error` status in migration rules table to indicate whether the rule translation has been failed * Callouts inside the translation tab in details flyout * Updated `Fully translated` status title into `Translated` ### Known issue There is an issue with the autocompletion menu of the ES|QL query editor component. It is being shifted. It could be because we are using this component within the flyout and we might need to ask help from the team which takes care of it.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Dec 12, 2024
…ab in the flyout (elastic#11381) (elastic#203601) ## Summary [Internal link](elastic/security-team#10820) to the feature details These changes add a possibility to edit, validate and save custom migration rules: * There are new `edit`, `save` and `cancel` buttons in the translation tab of the details flyout for the non-installed custom rules * There is a new ES|QL query editing component in the translation tab which allows edit and validate the ES|QL query * On saving the ES|QL query the custom migration rule will be updated and based on the ES|QL validation a new `translation_result` might be set: `full` if query is valid, `partial` if query has syntax errors, `untraslated` if query is an empty string. ## Screen recording https://github.com/user-attachments/assets/59cfc56f-3de8-4f7a-a2f9-79cb3fdee1c7 ### Other changes Next fixes and adjustments were also implemented as part of this PR: * `Error` status in migration rules table to indicate whether the rule translation has been failed * Callouts inside the translation tab in details flyout * Updated `Fully translated` status title into `Translated` ### Known issue There is an issue with the autocompletion menu of the ES|QL query editor component. It is being shifted. It could be because we are using this component within the flyout and we might need to ask help from the team which takes care of it. (cherry picked from commit 668f776)
kibanamachine
added a commit
that referenced
this issue
Dec 12, 2024
…tion tab in the flyout (#11381) (#203601) (#204078) # Backport This will backport the following commits from `main` to `8.x`: - [[Rules migration] ES|QL query editing and validation in translation tab in the flyout (#11381) (#203601)](#203601) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-12T16:22:38Z","message":"[Rules migration] ES|QL query editing and validation in translation tab in the flyout (#11381) (#203601)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nThese changes add a possibility to edit, validate and save custom\r\nmigration rules:\r\n* There are new `edit`, `save` and `cancel` buttons in the translation\r\ntab of the details flyout for the non-installed custom rules\r\n* There is a new ES|QL query editing component in the translation tab\r\nwhich allows edit and validate the ES|QL query\r\n* On saving the ES|QL query the custom migration rule will be updated\r\nand based on the ES|QL validation a new `translation_result` might be\r\nset: `full` if query is valid, `partial` if query has syntax errors,\r\n`untraslated` if query is an empty string.\r\n\r\n## Screen recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/59cfc56f-3de8-4f7a-a2f9-79cb3fdee1c7\r\n\r\n### Other changes\r\n\r\nNext fixes and adjustments were also implemented as part of this PR:\r\n* `Error` status in migration rules table to indicate whether the rule\r\ntranslation has been failed\r\n* Callouts inside the translation tab in details flyout\r\n* Updated `Fully translated` status title into `Translated`\r\n\r\n### Known issue\r\n\r\nThere is an issue with the autocompletion menu of the ES|QL query editor\r\ncomponent. It is being shifted. It could be because we are using this\r\ncomponent within the flyout and we might need to ask help from the team\r\nwhich takes care of it.","sha":"668f776583a60d35283a119fa007f7af9d1c57da","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","backport:prev-minor"],"title":"[Rules migration] ES|QL query editing and validation in translation tab in the flyout (#11381)","number":203601,"url":"https://github.com/elastic/kibana/pull/203601","mergeCommit":{"message":"[Rules migration] ES|QL query editing and validation in translation tab in the flyout (#11381) (#203601)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nThese changes add a possibility to edit, validate and save custom\r\nmigration rules:\r\n* There are new `edit`, `save` and `cancel` buttons in the translation\r\ntab of the details flyout for the non-installed custom rules\r\n* There is a new ES|QL query editing component in the translation tab\r\nwhich allows edit and validate the ES|QL query\r\n* On saving the ES|QL query the custom migration rule will be updated\r\nand based on the ES|QL validation a new `translation_result` might be\r\nset: `full` if query is valid, `partial` if query has syntax errors,\r\n`untraslated` if query is an empty string.\r\n\r\n## Screen recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/59cfc56f-3de8-4f7a-a2f9-79cb3fdee1c7\r\n\r\n### Other changes\r\n\r\nNext fixes and adjustments were also implemented as part of this PR:\r\n* `Error` status in migration rules table to indicate whether the rule\r\ntranslation has been failed\r\n* Callouts inside the translation tab in details flyout\r\n* Updated `Fully translated` status title into `Translated`\r\n\r\n### Known issue\r\n\r\nThere is an issue with the autocompletion menu of the ES|QL query editor\r\ncomponent. It is being shifted. It could be because we are using this\r\ncomponent within the flyout and we might need to ask help from the team\r\nwhich takes care of it.","sha":"668f776583a60d35283a119fa007f7af9d1c57da"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203601","number":203601,"mergeCommit":{"message":"[Rules migration] ES|QL query editing and validation in translation tab in the flyout (#11381) (#203601)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nThese changes add a possibility to edit, validate and save custom\r\nmigration rules:\r\n* There are new `edit`, `save` and `cancel` buttons in the translation\r\ntab of the details flyout for the non-installed custom rules\r\n* There is a new ES|QL query editing component in the translation tab\r\nwhich allows edit and validate the ES|QL query\r\n* On saving the ES|QL query the custom migration rule will be updated\r\nand based on the ES|QL validation a new `translation_result` might be\r\nset: `full` if query is valid, `partial` if query has syntax errors,\r\n`untraslated` if query is an empty string.\r\n\r\n## Screen recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/59cfc56f-3de8-4f7a-a2f9-79cb3fdee1c7\r\n\r\n### Other changes\r\n\r\nNext fixes and adjustments were also implemented as part of this PR:\r\n* `Error` status in migration rules table to indicate whether the rule\r\ntranslation has been failed\r\n* Callouts inside the translation tab in details flyout\r\n* Updated `Fully translated` status title into `Translated`\r\n\r\n### Known issue\r\n\r\nThere is an issue with the autocompletion menu of the ES|QL query editor\r\ncomponent. It is being shifted. It could be because we are using this\r\ncomponent within the flyout and we might need to ask help from the team\r\nwhich takes care of it.","sha":"668f776583a60d35283a119fa007f7af9d1c57da"}}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I can't find anything in the docs about this, so apologies if I missed it.
We don't seem to have any documentation around the little
^
arrow at the bottom of visualisations that lets you see the data table, the request we build and send and it's response, and various statistics of the request.Can we add something please?
The text was updated successfully, but these errors were encountered: