Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector table needs a better display when there are multiple columns #112176

Closed
bhavyarm opened this issue Sep 14, 2021 · 13 comments · Fixed by #155119
Closed

Inspector table needs a better display when there are multiple columns #112176

bhavyarm opened this issue Sep 14, 2021 · 13 comments · Fixed by #155119
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Inspector Inspector infrastructure and implementations impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@bhavyarm
Copy link
Contributor

Kibana version: 7.15.0 BC5

Elasticsearch version: 7.15.0 BC5

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: If there are multiple columns - inspector table needs to display data better. Right now - user cannot read the first column well in the screenshot below and also the spacing between seems off.

The screenshot if from data table of flights dashboard ( new in 7.15)

Screen Shot 2021-09-13 at 11 10 18 AM

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Inspector Inspector infrastructure and implementations Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@flash1293 flash1293 added Team:AppServices and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Sep 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Sep 27, 2021
@ThomThomson ThomThomson added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:AppServicesSv labels Mar 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor

Reassigning this to the Data Discovery team because it looks like this table lives in the Data plugin.

@ThomThomson ThomThomson added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Apr 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal
Copy link
Member

kertal commented Apr 13, 2023

Reassigning it to @elastic/kibana-visualizations because it doesn't look like a saved search, also I think this might be closable since it should be powered by EuiDataGrid in the meanwhile?

@kertal kertal added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Apr 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@kertal kertal removed the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Apr 13, 2023
@stratoula
Copy link
Contributor

stratoula commented Apr 13, 2023

This problem exists for every inspector table that has many columns. So this is not only a visualizations problem.

This table is created in the data plugin so this is why Devon added the discovery team here. I dont know who should own the table_inspector_view (possibly the team that owns the inspector) but moving this issue among the teams is not the solution. :)

https://github.com/elastic/kibana/blob/main/src/plugins/data/public/utils/table_inspector_view/components/data_table.tsx#L194

image

@elastic/eui-design it seems that the EuiInMemoryTable is not very responsive here. Is it a know bug? Is there any property we can use to make it render better or should I create a bug in the EUI repo?

@kertal
Copy link
Member

kertal commented Apr 13, 2023

@stratoula thx a lot! agreed we shouldn't move this issue between the team, TIL about his and that it's actually part of the data plugin :)

@cee-chen
Copy link
Contributor

cee-chen commented Apr 13, 2023

https://github.com/orgs/elastic/teams/eui-design it seems that the EuiInMemoryTable is not very responsive here. Is it a know bug? Is there any property we can use to make it render better or should I create a bug in the EUI repo?

There's only so much a table can do within the constraints of the # of items in the table and its container size. This is not a bug, this is simply how native tables behave.

My suggestion is that if you know your table will have a ton of content, give it a .eui-xScroll class (to ensure it scrolls if it has too much content), and set a tableLayout="auto" prop on the table. You'll then also want to set a min-width on each table header cell to ensure each column renders as expected.

Example CodeSandbox: https://codesandbox.io/s/runtime-haze-kxbicx?file=/demo.tsx:2055-2524

@stratoula
Copy link
Contributor

@cee-chen this sounds good, thanx!

@kertal
Copy link
Member

kertal commented Apr 18, 2023

@cee-chen thx and also thx @stratoula for following up, should we move this back to the @elastic/kibana-data-discovery domain? Or should we flip a 🪙 ... heads or tails?

@stratoula
Copy link
Contributor

@kertal dont worry, I have it on my list :)

@stratoula stratoula self-assigned this Apr 18, 2023
@stratoula stratoula removed the blocked label Apr 18, 2023
stratoula added a commit that referenced this issue Apr 18, 2023
## Summary

Fixes #112176

Improves the way the inspector table is rendered when there are multiple
columns. I just applied the eui team feedback

**Now**

<img width="1257" alt="image"
src="https://user-images.githubusercontent.com/17003240/232727448-561cd07a-84ec-472f-9968-27631ef9f4f1.png">


**Before**
<img width="875" alt="image"
src="https://user-images.githubusercontent.com/17003240/232727840-24514f38-0a6f-47a3-89ed-adc0bc7ea2f0.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Inspector Inspector infrastructure and implementations impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants