-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inspector table needs a better display when there are multiple columns #112176
Comments
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
Pinging @elastic/kibana-app-services (Team:AppServices) |
Pinging @elastic/kibana-presentation (Team:Presentation) |
Reassigning this to the Data Discovery team because it looks like this table lives in the Data plugin. |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Reassigning it to @elastic/kibana-visualizations because it doesn't look like a saved search, also I think this might be closable since it should be powered by EuiDataGrid in the meanwhile? |
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
This problem exists for every inspector table that has many columns. So this is not only a visualizations problem. This table is created in the data plugin so this is why Devon added the discovery team here. I dont know who should own the table_inspector_view (possibly the team that owns the inspector) but moving this issue among the teams is not the solution. :) @elastic/eui-design it seems that the EuiInMemoryTable is not very responsive here. Is it a know bug? Is there any property we can use to make it render better or should I create a bug in the EUI repo? |
@stratoula thx a lot! agreed we shouldn't move this issue between the team, TIL about his and that it's actually part of the |
There's only so much a table can do within the constraints of the # of items in the table and its container size. This is not a bug, this is simply how native tables behave. My suggestion is that if you know your table will have a ton of content, give it a Example CodeSandbox: https://codesandbox.io/s/runtime-haze-kxbicx?file=/demo.tsx:2055-2524 |
@cee-chen this sounds good, thanx! |
@cee-chen thx and also thx @stratoula for following up, should we move this back to the @elastic/kibana-data-discovery domain? Or should we flip a 🪙 ... heads or tails? |
@kertal dont worry, I have it on my list :) |
## Summary Fixes #112176 Improves the way the inspector table is rendered when there are multiple columns. I just applied the eui team feedback **Now** <img width="1257" alt="image" src="https://user-images.githubusercontent.com/17003240/232727448-561cd07a-84ec-472f-9968-27631ef9f4f1.png"> **Before** <img width="875" alt="image" src="https://user-images.githubusercontent.com/17003240/232727840-24514f38-0a6f-47a3-89ed-adc0bc7ea2f0.png">
Kibana version: 7.15.0 BC5
Elasticsearch version: 7.15.0 BC5
Server OS version: darwin_x86_64
Browser version: chrome latest
Browser OS version: OS X
Original install method (e.g. download page, yum, from source, etc.): from staging
Describe the bug: If there are multiple columns - inspector table needs to display data better. Right now - user cannot read the first column well in the screenshot below and also the spacing between seems off.
The screenshot if from data table of flights dashboard ( new in 7.15)
The text was updated successfully, but these errors were encountered: