Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/update·ts - alerting api integration security and spaces enabled Alerts alerts update "after all" hook in "update" #110801

Closed
kibanamachine opened this issue Sep 1, 2021 · 8 comments · Fixed by #111366
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort skipped-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.16.0

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 1, 2021

A test failed on a tracked branch

Error: expected 204 "No Content", got 409 "Conflict"
    at Test._assertStatus (/dev/shm/workspace/parallel/19/kibana/node_modules/supertest/lib/test.js:268:12)
    at Test._assertFunction (/dev/shm/workspace/parallel/19/kibana/node_modules/supertest/lib/test.js:283:11)
    at Test.assert (/dev/shm/workspace/parallel/19/kibana/node_modules/supertest/lib/test.js:173:18)
    at assert (/dev/shm/workspace/parallel/19/kibana/node_modules/supertest/lib/test.js:131:12)
    at /dev/shm/workspace/parallel/19/kibana/node_modules/supertest/lib/test.js:128:5
    at Test.Request.callback (/dev/shm/workspace/parallel/19/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:718:3)
    at /dev/shm/workspace/parallel/19/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:906:18
    at IncomingMessage.<anonymous> (/dev/shm/workspace/parallel/19/kibana/node_modules/supertest/node_modules/superagent/lib/node/parsers/json.js:19:7)
    at endReadableNT (internal/streams/readable.js:1317:12)
    at processTicksAndRejections (internal/process/task_queues.js:82:21)

First failure: Jenkins Build

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Sep 1, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 1, 2021
@mistic mistic added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Sep 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 1, 2021
@legrego legrego added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) and removed Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Sep 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

1 similar comment
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

spalger added a commit that referenced this issue Sep 1, 2021
spalger added a commit that referenced this issue Sep 1, 2021
(cherry picked from commit 38d08c4)
@spalger
Copy link
Contributor

spalger commented Sep 1, 2021

Loads of recent failures

image

Skipped
master/8.0: 38d08c4
7.x/7.16: 8b26ec5

@gmmorris gmmorris added the Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework label Sep 2, 2021
@pmuellr
Copy link
Member

pmuellr commented Sep 2, 2021

I think this is from here!?!?!:

Here's that code:

async removeAll() {
await Promise.all(
this.objectsToRemove.map(({ spaceId, id, type, plugin }) => {
return this.supertest
.delete(`${getUrlPrefix(spaceId)}/api/${plugin}/${type}/${id}`)
.set('kbn-xsrf', 'foo')
.expect(204);
})
);
this.objectsToRemove = [];
}

Not clear how we could get a 409 on a delete with no OCC. correction: I assumed this was a SO delete, but of course it's a rule delete, so there's likely some OCCish stuff there ... OR it could actually be a connector delete ...

@mikecote
Copy link
Contributor

mikecote commented Sep 2, 2021

Seems like the switch to multiple-isolated makes this function return versioning (by passing in a non-empty preflightResult now) which will cause the delete to return 409 (docs) if the document is updated between the read/delete calls.

@exalate-issue-sync exalate-issue-sync bot added impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort labels Sep 29, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort skipped-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.16.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants