Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability RAC] Remove cell actions from all columns #108150

Closed
mgiota opened this issue Aug 11, 2021 · 4 comments
Closed

[Observability RAC] Remove cell actions from all columns #108150

mgiota opened this issue Aug 11, 2021 · 4 comments
Assignees
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete v7.15.0 v8.0.0

Comments

@mgiota
Copy link
Contributor

mgiota commented Aug 11, 2021

📝 Summary

The Copy to keyboard and Expand icons should be removed from all columns of the Observability Alerts table. Removing the cell actions will fix the issue of leading to a broken empty page when clicking on the Expand icon.

Screenshot 2021-08-11 at 10 34 35

✔️ Acceptance criteria

  • Copy to keyboard button should be removed from all columns
  • Expand button should be removed from all columns

Relates to #108119

@mgiota mgiota added v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services auto-backport Deprecated - use backport:version if exact versions are needed Theme: rac label obsolete v7.15.0 labels Aug 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@mgiota
Copy link
Contributor Author

mgiota commented Aug 13, 2021

After our RAC meeting there were discussing around keeping the copy button in order to be consistent with other solutions.

2nd button (expand/popover icon) comes from EuiDataGrid. @michaelolo24 I haven't looked into that yet, in case you already figured it out, keep me in the loop.

@katrin-freihofner

@mgiota
Copy link
Contributor Author

mgiota commented Aug 16, 2021

@katrin-freihofner What shall we do with the copy icon?

Regarding broken expand icon looks like there is a fix from Security team #108616. I am checkin it now. Shall we keep the icon if it is fixed? This way we will be consistent with Security team

Here's how the expand icon looks like with the fix
Screenshot 2021-08-16 at 11 53 59

@katrin-freihofner
Copy link
Contributor

@mgiota looks good, let's keep it that way.

@mgiota mgiota closed this as completed Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete v7.15.0 v8.0.0
Projects
None yet
Development

No branches or pull requests

3 participants