Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC] Filter active/recovered status #108119

Closed
2 tasks
mgiota opened this issue Aug 10, 2021 · 5 comments · Fixed by #108648
Closed
2 tasks

[RAC] Filter active/recovered status #108119

mgiota opened this issue Aug 10, 2021 · 5 comments · Fixed by #108648
Assignees
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete v7.15.0 v8.0.0

Comments

@mgiota
Copy link
Contributor

mgiota commented Aug 10, 2021

📝 Summary

In the Observability alerts table user should have the option to filter by the alert status(kibana.alert.system_status), which can be either active or recovered. This shouldn't be confused with the workflow status (kibana.alert.workflow_status) which can be open, acknowledged, closed

✔️ Acceptance criteria

  • add the filter actions to the status column similar to the security solution.
  • when page loads the “active” state should already be filtered in.

screenshot_2021-08-10_at_14 58 13

Depends on #108150

@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 10, 2021
@mgiota mgiota added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Aug 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 10, 2021
@mgiota mgiota added v7.15.0 v8.0.0 Theme: rac label obsolete auto-backport Deprecated - use backport:version if exact versions are needed labels Aug 10, 2021
@mgiota
Copy link
Contributor Author

mgiota commented Aug 12, 2021

I checked current implementation and filter actions are being applied to all columns (whole row), whereas we would like to apply them only to one column, the status column. If we apply them to all columns, then I guess the reason field would be problematic, since it is not analyzed.

@jasonrhodes who should I tag from security team to check if there is already a way to add filter actions per column? I am a bit blocked with broken environment. I can check it out further once my environment is up and running

@jasonrhodes
Copy link
Member

I think we need to proceed with applying this to all columns for now and we can circle back on whether it's possible (or useful, even) to have different hover actions per column/cell.

The "reason" field won't be totally problematic in this case because it will filter for the exact reason, which will work since the field is a "keyword" field. It will have issues because some rule types are not indexing the reason, so those alerts will not show up even if their reason matches, but there's nothing we can do there for now.

@mgiota mgiota self-assigned this Aug 13, 2021
@mgiota
Copy link
Contributor Author

mgiota commented Aug 13, 2021

@jasonrhodes Ok agree.

I need a clarification, the id we get from the status field at the moment is alert.kibana.status. To my understanding it should be alert.kibana.system_status, right?

Regarding reason there are a couple of bugs at the moment. I am writing them down and we should handle them in another ticket:

  • clicking on the filter in button filters by kibana.alert.rule.name instead of kibana.alert.reason
  • if I manually type kibana.alert.reason: 'CPU' or just CPU in the urlbar, I don't get any results, which is what I mention in this ticket [Observability RAC]: Search a term in the reason field doesn't seem to work #108177. You say it should work since the field is a "keyword" field, but it doesn't according to the ticket I created. We discussed about that again, but it is still not clear to me what needs to be done to make it work (haven't looked into it though, since I got the impression you are aware of how it should work). I guess it is somehow connected to the first bullet above that is reads from kibana.alert.rule.name. Once above is fixed, this one should be fixed I guess. cc @weltenwort

@weltenwort
Copy link
Member

ℹ️ To add some more context: Currently we have constants for both ALERT_STATUS and ALERT_SYSTEM_STATUS. The former is used everywhere across the security, uptime, apm, rule_registry, and observability apps. The latter is not used anywhere yet.

Regarding the reason field, I commented on your other issue. The question becomes whether we want the field to be a keyword or a text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants