Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 'No Logged Actions' message blinks in the Activity Log. #107129

Closed
ghost opened this issue Jul 29, 2021 · 9 comments · Fixed by #110233
Closed

The 'No Logged Actions' message blinks in the Activity Log. #107129

ghost opened this issue Jul 29, 2021 · 9 comments · Fixed by #110233
Assignees
@ashokaditya
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. OLM Sprint QA:Validated Issue has been validated by QA Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.15.0

Comments

@ghost
Copy link

ghost commented Jul 29, 2021

Describe the bug:
The 'No Logged Actions' message blinks in the Activity Log.

Build Details:

VERSION: 7.14.0-BC5
BUILD: 42722
COMMIT: fb2c86a
ARTIFACT: https://staging.elastic.co/7.14.0-20ebeb16/summary-7.14.0.html

Preconditions:
Elastic 7.14.0 environment should be deployed.

Steps to Reproduce:

  1. Navigate to the Endpoints tab under security app
  2. Click on the Hostname.
  3. Navigate to the Activity Log.
  4. Observe that the 'No Logged Actions' message blinks in the Activity Log.

Test data:
N/A

Impacted Test case(s):
N/A

Actual Result:
The 'No Logged Actions' message blinks in the Activity Log.

Expected Result:
The 'No Logged Actions' message shouldn't blink in the Activity Log.

What's Working:
N/A

What's Not Working:
N/A

Screen-Recording:

Administration.-.Kibana.-.Google.Chrome.2021-07-29.13-58-39.mp4

Logs:
N/A
@ghost ghost added bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Jul 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost
Copy link
Author

ghost commented Jul 29, 2021

@manishgupta-qasource Please review.

@manishgupta-qasource
Copy link

Reviewed & assigned to @kevinlog

@manishgupta-qasource manishgupta-qasource added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Jul 29, 2021
@dasansol92 dasansol92 self-assigned this Jul 29, 2021
@dasansol92 dasansol92 added OLM Sprint Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Jul 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@dasansol92
Copy link
Contributor

The Api call is done twice when it throws an error (there is no activity logs for host) and the view keeps inconsistent. We could display a loader until the data has been loaded or not properly and then show the data or the empty prompt.
@kevinlog let me know if this needs to be done for 7.14.0 or just tag this for 7.14.1

@kevinlog kevinlog added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Jul 29, 2021
@dasansol92 dasansol92 removed their assignment Aug 4, 2021
@ghost
Copy link

ghost commented Aug 18, 2021

Hi @kevinlog

Today we have done exploratory on 8.0.0 Snapshot build and found that this issue is also occurring as well as "pick start and end date" blinks for few times.

Please found below build and testing details.

Build Details:
VERSION: 8.0.0-SNAPSHOT
BUILD: 45390
COMMIT: b1f38f4
ARTIFACT: https://artifacts-api.elastic.co/v1/search/8.0.0-SNAPSHOT

Screen Recording

Blink.mp4

Thanks!!

@kevinlog kevinlog added v7.15.0 impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Aug 25, 2021
@kevinlog kevinlog assigned ashokaditya and unassigned kevinlog Aug 25, 2021
@kevinlog
Copy link
Contributor

@ashokaditya - I chatted with @caitlinbetz offline. Can you take a look at this for 7.15? If you think it's feasible to merge, we can fix for 7.15. If it's more complicated, can defer to 7.16.

@ashokaditya ashokaditya mentioned this issue Aug 26, 2021
Merged
4 tasks
ashokaditya added a commit that referenced this issue Aug 30, 2021
@ashokaditya @kibanamachine
[Security Solution][Endpoint] Fix activity log load empty state flick…
22e5565 
…er (#110233)

* account for API errors and uninitialized state before fetching data

fixes /issues/107129

* better name

refs /pull/102261

* don't show date picker when loading data initially

fixes /issues/107129

* use a readable selector instead

review changes

* remove redundant data fetch using paging action on tab switch.

refs /pull/102261

* remove redundant validation

review comments

Co-authored-by: Kibana Machine <[email protected]>
kibanamachine added a commit to kibanamachine/kibana that referenced this issue Aug 30, 2021
@ashokaditya @kibanamachine
[Security Solution][Endpoint] Fix activity log load empty state flick…
466ef48 
…er (elastic#110233)

* account for API errors and uninitialized state before fetching data

fixes elastic/issues/107129

* better name

refs elastic/pull/102261

* don't show date picker when loading data initially

fixes elastic/issues/107129

* use a readable selector instead

review changes

* remove redundant data fetch using paging action on tab switch.

refs elastic/pull/102261

* remove redundant validation

review comments

Co-authored-by: Kibana Machine <[email protected]>
kibanamachine added a commit to kibanamachine/kibana that referenced this issue Aug 30, 2021
@ashokaditya @kibanamachine
[Security Solution][Endpoint] Fix activity log load empty state flick…
eb00c08 
…er (elastic#110233)

* account for API errors and uninitialized state before fetching data

fixes elastic/issues/107129

* better name

refs elastic/pull/102261

* don't show date picker when loading data initially

fixes elastic/issues/107129

* use a readable selector instead

review changes

* remove redundant data fetch using paging action on tab switch.

refs elastic/pull/102261

* remove redundant validation

review comments

Co-authored-by: Kibana Machine <[email protected]>
kibanamachine added a commit that referenced this issue Aug 30, 2021
@kibanamachine @ashokaditya
[Security Solution][Endpoint] Fix activity log load empty state flick…
91822c9 
…er (#110233) (#110526)

* account for API errors and uninitialized state before fetching data

fixes /issues/107129

* better name

refs /pull/102261

* don't show date picker when loading data initially

fixes /issues/107129

* use a readable selector instead

review changes

* remove redundant data fetch using paging action on tab switch.

refs /pull/102261

* remove redundant validation

review comments

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Ashokaditya <[email protected]>
kibanamachine added a commit that referenced this issue Sep 1, 2021
@kibanamachine @ashokaditya
[Security Solution][Endpoint] Fix activity log load empty state flick…
41275ab 
…er (#110233) (#110525)

* account for API errors and uninitialized state before fetching data

fixes /issues/107129

* better name

refs /pull/102261

* don't show date picker when loading data initially

fixes /issues/107129

* use a readable selector instead

review changes

* remove redundant data fetch using paging action on tab switch.

refs /pull/102261

* remove redundant validation

review comments

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Ashokaditya <[email protected]>
@ashokaditya ashokaditya added the QA:Ready for Testing Code is merged and ready for QA to validate label Sep 1, 2021
@ashokaditya ashokaditya reopened this Sep 1, 2021
@ghost
Copy link
Author

ghost commented Sep 3, 2021

Hi @kevinlog,

We tested this ticket on the latest 7.15.0-BC4 build & found that the issue is now fixed. Please find below the exact testing details:

Build Details:

VERSION:7.15.0-BC4
BUILD: 43886
COMMIT: 29a6969dc230abf16dc65a41c535cb534ae64fa7
ARTIFACT:https://staging.elastic.co/7.15.0-9e0972b3/summary-7.15.0.html

Screen-Recording

Administration.-.Kibana.-.Google.Chrome.2021-09-03.15-33-55.mp4

Hence, closing this issue and marking it as "Validated".

Thanks

@ghost ghost closed this as completed Sep 3, 2021
@ghost ghost added the QA:Validated Issue has been validated by QA label Sep 3, 2021
@muskangulati-qasource
Copy link

Bug Conversion

Thanks!

@muskangulati-qasource muskangulati-qasource removed the QA:Ready for Testing Code is merged and ready for QA to validate label Oct 6, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashokaditya ashokaditya

Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. OLM Sprint QA:Validated Issue has been validated by QA Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security Solution][Endpoint] Fix activity log load empty state flicker
6 participants
@ashokaditya @dasansol92 @elasticmachine @kevinlog @manishgupta-qasource @muskangulati-qasource