Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Remove EuiCodeEditor from service map storybook #106927

Closed
smith opened this issue Jul 27, 2021 · 1 comment · Fixed by #109290
Closed

[APM] Remove EuiCodeEditor from service map storybook #106927

smith opened this issue Jul 27, 2021 · 1 comment · Fixed by #109290
Assignees
@smith
Labels
Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture

Comments

@smith
Copy link
Contributor

smith commented Jul 27, 2021

EuiCodeEditor is deprecated. We're only using it in a storybook:

kibana/x-pack/plugins/apm/public/components/app/service_map/__stories__/cytoscape_example_data.stories.tsx

Lines 92 to 99 in b17200a

<EuiCodeEditor
mode="json"
theme="github"
width="100%"
value={json}
setOptions={{ fontSize: '12px' }}
isReadOnly
/>

Replace it with something else.
@smith smith added the Team:APM All issues that need APM UI Team support label Jul 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes added [zube]: Backlog technical debt Improvement of the software architecture and operational architecture labels Jul 28, 2021
@smith smith mentioned this issue Jul 28, 2021
Open
42 tasks
@smith smith self-assigned this Aug 18, 2021
smith added a commit to smith/kibana that referenced this issue Aug 19, 2021
@smith
Remove EuiCodeEditor from service map stories
0bc2e1c 
Replace with Monaco-based `CodeEditor` from kibanaReact.

Fixes elastic#106927.
@smith smith mentioned this issue Aug 19, 2021
Merged
smith added a commit that referenced this issue Aug 25, 2021
@smith
Remove EuiCodeEditor from service map stories (#109290)
a8cd0d1 
Replace with Monaco-based `CodeEditor` from kibanaReact.

Fixes #106927.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Aug 25, 2021
@smith @kibanamachine
Remove EuiCodeEditor from service map stories (elastic#109290)
787d683 
Replace with Monaco-based `CodeEditor` from kibanaReact.

Fixes elastic#106927.
kibanamachine added a commit that referenced this issue Aug 25, 2021
@kibanamachine @smith
Remove EuiCodeEditor from service map stories (#109290) (#110151)
a21db57 
Replace with Monaco-based `CodeEditor` from kibanaReact.

Fixes #106927.

Co-authored-by: Nathan L Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smith smith

Labels
Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove EuiCodeEditor from service map stories smith/kibana
4 participants
@smith @sorenlouv @elasticmachine @cauemarcondes