Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/alerts·ts - alerting api integration security and spaces enabled Alerts alerts alerts superuser at space1 should handle custom retry logic when appropriate #106492

Closed
kibanamachine opened this issue Jul 22, 2021 · 11 comments · Fixed by #111366
Closed

Failing test: X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/alerts·ts - alerting api integration security and spaces enabled Alerts alerts alerts superuser at space1 should handle custom retry logic when appropriate #106492

kibanamachine opened this issue Jul 22, 2021 · 11 comments · Fixed by #111366
Labels
estimate:small Small Estimated Level of Effort failed-test A test failure on a tracked branch, potentially flaky-test Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 22, 2021 •
edited
Loading

A test failed on a tracked branch

Error: retry.try timeout: Error: expected 0 to sort of equal 1
    at Assertion.assert (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/expect/expect.js:244:8)
    at /dev/shm/workspace/parallel/18/kibana/x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/alerts.ts:585:92
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at runAttempt (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry_for_success.ts:27:15)
    at retryForSuccess (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry_for_success.ts:66:21)
    at RetryService.try (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry.ts:31:12)
    at Context.<anonymous> (test/alerting_api_integration/security_and_spaces/tests/alerting/alerts.ts:549:19)
    at Object.apply (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
    at onFailure (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry_for_success.ts:17:9)
    at retryForSuccess (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry_for_success.ts:57:13)
    at RetryService.try (/dev/shm/workspace/parallel/18/kibana/test/common/services/retry/retry.ts:31:12)
    at Context.<anonymous> (test/alerting_api_integration/security_and_spaces/tests/alerting/alerts.ts:549:19)
    at Object.apply (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

First failure: Jenkins Build
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jul 22, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 22, 2021
@mistic mistic added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Jul 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 22, 2021
@mikecote
Copy link
Contributor

Closing as it seems to have only happened once.

@kibanamachine kibanamachine reopened this Aug 20, 2021
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

mistic added a commit that referenced this issue Aug 22, 2021
@mistic
skip flaky suite (#106492)
c2ec613
@mistic
Copy link
Member

mistic commented Aug 22, 2021 •
edited by tylersmalley
Loading

This test keeps failing and looks flaky. Skipping for now.

master/8.0: c2ec613
7.x/7.16: d1a8bbd
7.15: 41a8410

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

mistic added a commit that referenced this issue Aug 23, 2021
@mistic
skip flaky suite (#106492)
d1a8bbd
@gmmorris gmmorris added the Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework label Sep 2, 2021
@ymao1 ymao1 self-assigned this Sep 2, 2021
@ymao1 ymao1 mentioned this issue Sep 7, 2021
Merged
@gmmorris gmmorris added the estimate:small Small Estimated Level of Effort label Sep 20, 2021
@kibanamachine kibanamachine reopened this Oct 5, 2021
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 7.15

tylersmalley pushed a commit that referenced this issue Oct 5, 2021
@mistic
skip flaky suite (#106492)
9807691
@ymao1 ymao1 removed their assignment Dec 16, 2021
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 7.15

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 7.15

tylersmalley pushed a commit that referenced this issue Jan 19, 2022
@mistic
skip flaky suite (#106492)
41a8410
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
@mikecote mikecote moved this from Awaiting Triage to Todo in AppEx: ResponseOps - Execution & Connectors Jul 24, 2023
@ymao1
Copy link
Contributor

ymao1 commented Aug 8, 2023

The should handle custom retry logic when appropriate test is in https://github.com/elastic/kibana/blob/main/x-pack/test/alerting_api_integration/security_and_spaces/group2/tests/alerting/alerts.ts and there are no skipped tests in that file. Looks like they were re-enabled 4 months ago with this PR: #154167 and there has been no flakiness since then, so closing this issue.

@ymao1 ymao1 closed this as completed Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
estimate:small Small Estimated Level of Effort failed-test A test failure on a tracked branch, potentially flaky-test Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
AppEx: ResponseOps - Execution & Connectors
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Alerting] Fixing flaky tests ymao1/kibana
8 participants
@tylersmalley @gmmorris @kobelb @mikecote @mistic @ymao1 @elasticmachine @kibanamachine