Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visualize] Client Side caching #102622

Closed
stratoula opened this issue Jun 18, 2021 · 1 comment · Fixed by #105589
Closed

[Visualize] Client Side caching #102622

stratoula opened this issue Jun 18, 2021 · 1 comment · Fixed by #105589
Assignees
@alexwizp
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) performance Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

Describe the feature:
We could do some optimizations in order for our visualizations to cache the data in the browser and only fetch them when is necessary. Even if I change something that affects the chart and not the data (for example change the palette), a search request runs again.

We could use the session id in order to cache our search requests and only trigger them when is necessary.
Moreover, we could improve our performance if the searchSessionId from the dashboard is shared to the visualization that is edited. In that case, there is no need to re-fetch the data, as they were already fetched on the Dashboard.

Lens has already addressed it in a very smart way. Helpful resources:
@stratoula stratoula added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) performance Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula mentioned this issue Jun 23, 2021
Merged
2 tasks
@alexwizp alexwizp self-assigned this Jul 13, 2021
@alexwizp alexwizp mentioned this issue Jul 14, 2021
Merged
alexwizp added a commit to alexwizp/kibana that referenced this issue Jul 16, 2021
@alexwizp
[Visualize] Client Side caching
f53b790 
Closes: elastic#102622
alexwizp added a commit that referenced this issue Jul 19, 2021
@alexwizp @kibanamachine
[Visualize] Client Side caching (#105589)
dc45560 
* [Visualize] Client Side caching

Closes: #102622

* apply caching for returning to originatingApp

* fix case with 'save as' functiionality

Co-authored-by: Kibana Machine <[email protected]>
alexwizp added a commit to alexwizp/kibana that referenced this issue Jul 19, 2021
@alexwizp @kibanamachine
[Visualize] Client Side caching (elastic#105589)
6e9b2bb 
* [Visualize] Client Side caching

Closes: elastic#102622

* apply caching for returning to originatingApp

* fix case with 'save as' functiionality

Co-authored-by: Kibana Machine <[email protected]>
alexwizp added a commit that referenced this issue Jul 19, 2021
@alexwizp @kibanamachine
[Visualize] Client Side caching (#105589) (#106072)
e6d944a 
* [Visualize] Client Side caching

Closes: #102622

* apply caching for returning to originatingApp

* fix case with 'save as' functiionality

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) performance Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Visualize] Client Side caching alexwizp/kibana
3 participants
@elasticmachine @stratoula @alexwizp