[ML] filter out undefined values

elastic · Jun 3, 2021 · feb2b45 · feb2b45
1 parent 645e34f
commit feb2b45
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/x-pack/plugins/lens/public/heatmap_visualization/chart_component.tsx b/x-pack/plugins/lens/public/heatmap_visualization/chart_component.tsx
@@ -50,8 +50,6 @@ export const HeatmapComponent: FC<HeatmapRenderProps> = ({
   const tableId = Object.keys(data.tables)[0];
   const table = data.tables[tableId];
 
-  let chartData = table.rows;
-
   const xAxisColumnIndex = table.columns.findIndex((v) => v.id === args.xAccessor);
   const yAxisColumnIndex = table.columns.findIndex((v) => v.id === args.yAccessor);
 
@@ -64,6 +62,8 @@ export const HeatmapComponent: FC<HeatmapRenderProps> = ({
     return null;
   }
 
+  let chartData = table.rows.filter((v) => typeof v[args.valueAccessor!] === 'number');
+
   if (!yAxisColumn) {
     // required for tooltip
     chartData = chartData.map((row) => {
@@ -77,6 +77,8 @@ export const HeatmapComponent: FC<HeatmapRenderProps> = ({
   const xAxisMeta = xAxisColumn.meta;
   const isTimeBasedSwimLane = xAxisMeta.type === 'date';
 
+  // Fallback to the ordinal scale type when a single row of data is provided.
+  // Related issue https://github.com/elastic/elastic-charts/issues/1184
   const xScaleType =
     isTimeBasedSwimLane && chartData.length > 1 ? ScaleType.Time : ScaleType.Ordinal;