Fix test issues

elastic · Jun 8, 2021 · f9a9c9a · f9a9c9a
1 parent 4b81e5d
commit f9a9c9a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.tsx b/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.tsx
@@ -125,7 +125,7 @@ export function DimensionEditor(props: DimensionEditorProps) {
       {
         isDimensionComplete:
           prevOperationType === 'fullReference'
-            ? hasIncompleteColumns
+            ? !hasIncompleteColumns
             : Boolean(hypotheticalLayer.columns[columnId]),
       }
     );

diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_panel.test.tsx b/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_panel.test.tsx
@@ -930,7 +930,10 @@ describe('IndexPatternDimensionEditorPanel', () => {
         .simulate('click');
 
       // Now check that the dimension gets cleaned up on state update
-      expect(setState.mock.calls[0]).toEqual([expect.any(Function), { isDimensionComplete: true }]);
+      expect(setState.mock.calls[0]).toEqual([
+        expect.any(Function),
+        { isDimensionComplete: false },
+      ]);
       expect(setState.mock.calls[0][0](state)).toEqual({
         ...state,
         layers: {

diff --git a/x-pack/test/functional/apps/lens/smokescreen.ts b/x-pack/test/functional/apps/lens/smokescreen.ts
@@ -595,7 +595,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
 
       await PageObjects.lens.configureDimension({
         dimension: 'lnsXY_yDimensionPanel > lns-empty-dimension',
-        operation: 'minimum',
+        operation: 'min',
       });
 
       expect(await PageObjects.lens.getDimensionTriggerText('lnsXY_yDimensionPanel')).to.eql(