[Obs AI Assistant] Update serverless tests to use cookie auth instead…

… of API keys
elastic · Dec 6, 2024 · f8b1bc7 · f8b1bc7
1 parent 1b295fe
commit f8b1bc7
Showing 1 changed file with 11 additions and 27 deletions.
diff --git a/.../observability/ai_assistant/tests/knowledge_base/knowledge_base_user_instructions.spec.ts b/.../observability/ai_assistant/tests/knowledge_base/knowledge_base_user_instructions.spec.ts
@@ -77,34 +77,18 @@ export default function ApiTest({ getService }: FtrProviderContext) {
           { username: 'john', isPublic: false },
         ].map(async ({ username, isPublic }) => {
           const visibility = isPublic ? 'Public' : 'Private';
+          const user = username === 'editor' ? 'slsEditor' : 'slsAdmin';
 
-          if (username === 'editor') {
-            await observabilityAIAssistantAPIClient
-              .slsEditor({
-                endpoint: 'PUT /internal/observability_ai_assistant/kb/user_instructions',
-                params: {
-                  body: {
-                    id: `${visibility.toLowerCase()}-doc-from-${username}`,
-                    text: `${visibility} user instruction from "${username}"`,
-                    public: isPublic,
-                  },
-                },
-              })
-              .expect(200);
-          } else {
-            await observabilityAIAssistantAPIClient
-              .slsAdmin({
-                endpoint: 'PUT /internal/observability_ai_assistant/kb/user_instructions',
-                params: {
-                  body: {
-                    id: `${visibility.toLowerCase()}-doc-from-${username}`,
-                    text: `${visibility} user instruction from "${username}"`,
-                    public: isPublic,
-                  },
-                },
-              })
-              .expect(200);
-          }
+          await observabilityAIAssistantAPIClient[user]({
+            endpoint: 'PUT /internal/observability_ai_assistant/kb/user_instructions',
+            params: {
+              body: {
+                id: `${visibility.toLowerCase()}-doc-from-${username}`,
+                text: `${visibility} user instruction from "${username}"`,
+                public: isPublic,
+              },
+            },
+          }).expect(200);
         });
 
         await Promise.all(promises);